Merged
Conversation
|
Thanks for creating a PR for this, just today I was hoping this feature would come :) |
Owner
|
Very nice (one of the rare times I've had a PR where I changed nothing 😄). Of course this will break when the user has e.g. a shared folder or something as their timeline root. But that breaks a lot of things anyway, so wouldn't bother with it for now. Ideally we need the permissions flags for each file so we can make checks on the UI side, but not sure how feasible this is, peformance-wise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been looking for a 'perfect' self hosted gallery app for some time, and this is the best I could find so far. So thanks for this project!
While I am using this app though, I notice couple of features fell short, which are important for my use-case. So moving multiple photos from timeline and folders to another folder is the one I need at the moment (effectively fixes #204 - only move part though). So I decided to implement this. I understand that if this won't be prioritized (I'll use my fork anyway 😄) or cancelled all together.
Couple of notes:
MOVE, so just using it as similar to Nextcloud files.