Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action does not fail #27

Closed
GaboFDC opened this issue Jul 10, 2020 · 4 comments
Closed

Action does not fail #27

GaboFDC opened this issue Jul 10, 2020 · 4 comments
Assignees
@stack72
Labels
kind/bug Some behavior is incorrect or out of spec
Milestone
0.53

Comments

@GaboFDC
Copy link

GaboFDC commented Jul 10, 2020

The action should fail when there are errors.
In this case, no cloud backend config was provided, pulumi outputed the error, but the action didn't fail

image

Not sure, but some other errors may also be passing.
@leezen leezen added the bug label Jul 10, 2020
@leezen leezen added this to the current milestone Jul 14, 2020
@leezen leezen removed this from the current milestone Nov 2, 2020
@stack72 stack72 mentioned this issue Dec 31, 2020
Closed
29 tasks
@stack72
Copy link
Contributor

stack72 commented Dec 31, 2020

Closed as being tracked in #40

@stack72 stack72 closed this as completed Dec 31, 2020
@leezen leezen reopened this Jan 4, 2021
@infin8x
Copy link

infin8x commented Jan 11, 2021

Closing this in favor of #40, please comment if you disagree

@infin8x infin8x closed this as completed Jan 11, 2021
@infin8x
Copy link

infin8x commented Jan 11, 2021

Reopening this after chatting with @leezen, since this is just one component of #40

@infin8x infin8x reopened this Jan 11, 2021
@stack72 stack72 self-assigned this Feb 26, 2021
@stack72 stack72 added this to the 0.53 milestone Feb 26, 2021
@stack72
Copy link
Contributor

stack72 commented Feb 26, 2021

I am closing this out as we have just released v2 of our Action which is based on TypeScript and addresses this issue

@stack72 stack72 closed this as completed Feb 26, 2021
@infin8x infin8x added the kind/bug Some behavior is incorrect or out of spec label Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stack72 stack72

Labels
kind/bug Some behavior is incorrect or out of spec
Projects
None yet
Milestone
0.53
Development

No branches or pull requests
4 participants
@stack72 @infin8x @leezen @GaboFDC