Add beginnings of www content #1134
Conversation
Signed-off-by: Christian Nunciato <c@nunciato.org>
Signed-off-by: Christian Nunciato <c@nunciato.org>
Signed-off-by: Christian Nunciato <c@nunciato.org>
Signed-off-by: Christian Nunciato <c@nunciato.org>
Signed-off-by: Christian Nunciato <c@nunciato.org>
Signed-off-by: Christian Nunciato <c@nunciato.org>
Signed-off-by: Christian Nunciato <c@nunciato.org>
Signed-off-by: Christian Nunciato <c@nunciato.org>
Signed-off-by: Christian Nunciato <c@nunciato.org>
Signed-off-by: Christian Nunciato <c@nunciato.org>
Signed-off-by: Christian Nunciato <c@nunciato.org>
Signed-off-by: Christian Nunciato <c@nunciato.org>
Signed-off-by: Christian Nunciato <c@nunciato.org>
Signed-off-by: Christian Nunciato <c@nunciato.org>
Signed-off-by: Christian Nunciato <c@nunciato.org>
|
@chrsmith Can we merge this into |
|
What's the benefit of the extra |
Co-Authored-By: Justin Van Patten <jvp@justinvp.com>
justinvp
left a comment
justinvp
left a comment
There was a problem hiding this comment.
I did a quick scan of all the content, but did not look at it in detail. Other than my question about the assets dir (which we can deal with or not subsequently), looks good to me to merge into fusion.
| weight: 2 | ||
|
|
||
| hero_title: "Acceptable Use Policy" | ||
| url: "/acceptable-use" |
There was a problem hiding this comment.
As a subsequent exercise, I wonder if we should audit all the uses of url: and consider just placing these files where they should be, e.g. instead of having this in /content/legal/acceptable-use.md with a URL that makes it /acceptable-use, delete the url: front matter and just place the file directly in /content/acceptable-use.md
| @@ -0,0 +1,15 @@ | |||
| --- | |||
| title: "Cloud Delivery Service" | |||
| date: 2018-06-01T15:10:06-07:00 | |||
There was a problem hiding this comment.
As a subsequent exercise, we should consider deleting the dates from most of these content files, as I think they're just "dead code", except for blog posts where date is used.
| title: "Cloud Delivery Service" | ||
| date: 2018-06-01T15:10:06-07:00 | ||
| layout: "cloud-delivery-service" | ||
| draft: true |
There was a problem hiding this comment.
We should also do an audit of draft: at some point. Are these pages not being published currently? If not, can we remove? If they are we should delete the draft: from the front matter.
There was a problem hiding this comment.
I would, yeah. No sense keeping around what clearly isn't in use!
| </div> | ||
| <div class="anim_textbox code_display_textbox"> | ||
| <div class="code-display"> | ||
| <pre><code class="javascript hljs">import * as k8s from "@pulumi/kubernetes"; |
There was a problem hiding this comment.
Just a note: In the short term, we'll want to get https://highlightjs.org setup so these code snippets are syntax highlighted. The blog also uses highlight.js for highlighting code snippets, so it'd also highlight existing code snippets in blog posts (until they've been converted to markdown and get Hugo's built-in Chroma-based highlighting).
There was a problem hiding this comment.
cc: @chrsmith as he mentioned he's converting the blog posts over to use Hugo's highlight shortcode. Although, I suggest we standardize on Code Fences long-term for most code snippets (unless we need something more specialized like line numbers and line highlighting), as that's what's used everywhere else in existing docs content and in API doc comments in package repos.
None, really -- I'm just as happy having things at /images, etc. I'll make that change. |
Signed-off-by: Christian Nunciato <c@nunciato.org>
Signed-off-by: Christian Nunciato <c@nunciato.org>
This is still a WIP, but is in a good-enough spot to merge into
fusionin order to keep @chrsmith unblocked on the blog work.