Skip to content

Fix bug in lang chooser #1249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2019
Merged

Fix bug in lang chooser #1249

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 31 additions & 27 deletions assets/js/langchoose.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,18 +13,12 @@ function selectLanguage(lang) {

// Change the active tab.
var langTabs = 0;
$("a").each(function (i, e) {
var classes = getElemClasses(e);
for (var i = 0; i < classes.length; i++) {
if (classes[i] === "langtab") {
langTabs++;
if (e.innerText.toLowerCase() === lang) {
$(e).addClass("is-active");
} else {
$(e).removeClass("is-active");
}
break;
}
$("a.langtab").each(function (i, e) {
langTabs++;
if (e.innerText.toLowerCase() === lang) {
$(e).addClass("is-active");
} else {
$(e).removeClass("is-active");
}
});

Expand Down Expand Up @@ -87,26 +81,36 @@ function selectLanguage(lang) {
// The first time the DOM is finished loading, select the right language. If no language is set as the preferred
// language yet, then JavaScript is chosen as the preferred language as a default.
$(function() {
// For every language tab, inject a handler and make the correct one hidden.
$("a").each(function (i, e) {
var classes = getElemClasses(e);
for (var i = 0; i < classes.length; i++) {
if (classes[i] === "langtab") {
var lang = e.innerText.toLowerCase();
e.addEventListener("click", function() {
selectLanguage(lang);
});
break;
}
}
var tabLangsOnPage = {};
$("a.langtab").each(function (i, e) {
var lang = e.innerText.toLowerCase();

// Save the languages we've seen.
tabLangsOnPage[lang] = true;

// For every language tab, inject a handler and make the correct one hidden.
e.addEventListener("click", function() {
selectLanguage(lang);
});
});

// Now select the right language based on whether there's a cookie (defaulting to JavaScript).
var tabLangsOnPageKeys = Object.keys(tabLangsOnPage);

// If we didn't find any lang tabs, there's nothing else to do.
if (tabLangsOnPageKeys.length === 0) {
return;
}

// Now select the right language based on whether there's a cookie, defaulting to JavaScript,
// if it's among the tabs, otherwise falling back to the first lang we find.
var langCookie = decodeURIComponent(
document.cookie.replace(/(?:(?:^|.*;\s*)pulumi_language\s*\=\s*([^;]*).*$)|^.*$/, "$1"));
if (langCookie) {

if (langCookie && tabLangsOnPage.hasOwnProperty(langCookie)) {
selectLanguage(langCookie);
} else {
} else if (tabLangsOnPage.hasOwnProperty("javascript")) {
selectLanguage("javascript");
} else if (tabLangsOnPageKeys.length > 0) {
selectLanguage(tabLangsOnPageKeys[0]);
}
});