Skip to content

Conversation

@kramhuber
Copy link
Contributor

Adds task modes to Task docs.

@claude
Copy link
Contributor

claude bot commented Oct 13, 2025

PR Review Summary

This PR adds documentation for Neo task operating modes. The content is helpful, but there are several style issues that need to be addressed per STYLE-GUIDE.md.

Issues Found

1. Inconsistent capitalization of mode names (lines 36-38)

  • Line 37: "Balanced Mode" should be "Balanced mode"
  • Line 38: "Auto Mode" should be "Auto mode"
  • Per STYLE-GUIDE.md: use lowercase for non-proper nouns

2. Missing CLI command formatting (line 36)

  • "running pulumi preview" and "running pulumi up" need backticks
  • Should be: running pulumi preview and running pulumi up
  • Per STYLE-GUIDE.md line 126: CLI commands must be wrapped in backticks

3. Awkward phrasing (line 37)

  • "Neo will only request approvals before running up" is incomplete
  • Suggest: "Neo will only request approval before running pulumi up"

4. Grammar issue (line 38)

  • "Neo will not ask for any approvals" should use consistent terminology
  • Suggest: "Neo will not request any approvals" (matches line 36 usage)

5. Alt text needs improvement (line 40)

  • Current: "The modes Neo can operate in"
  • Suggest more descriptive text for accessibility: "Diagram showing three Neo operating modes: Review, Balanced, and Auto"

6. Content clarity (line 34)

  • "At any time during a task lifecycle, the operating mode can be set to" - can users actually switch modes mid-task?
  • If not, clarify when the mode selection occurs

Minor Notes

  • New image file is properly formatted (PNG, 814x262)
  • entity-context.png was modified but not mentioned in PR description
  • File ends with newline

Recommendation

Address the capitalization and CLI formatting issues before merging. The content is valuable documentation once these style issues are fixed.

@pulumi-bot
Copy link
Collaborator

@pulumi-bot
Copy link
Collaborator

Copy link
Contributor

@CamSoper CamSoper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! :shipit:

@CamSoper
Copy link
Contributor

CamSoper commented Oct 14, 2025

@kramhuber I took the liberty of merging from master for you so you don't have to sort through the merge conflicts the big reorg introduced to this PR. Should be good to merge whenever!

@kramhuber kramhuber enabled auto-merge (squash) October 14, 2025 23:39
@pulumi-bot
Copy link
Collaborator

@kramhuber kramhuber merged commit 6199ccf into master Oct 14, 2025
8 checks passed
@kramhuber kramhuber deleted the mhuber/neo-task-modes branch October 14, 2025 23:46
kimberleyamackenzie pushed a commit that referenced this pull request Oct 15, 2025
* add task mode details

* claude nits

---------

Co-authored-by: Cam <cam.soper@outlook.com>
kimberleyamackenzie added a commit that referenced this pull request Oct 17, 2025
* Neo mode first draft

* Second draft

* Clean up and adjust styles

* Mobile responsiveness

* Animation

* Feedback and suggestion pills draft

* Hide copilot from homepage in favor of Neo takeover

* Move JS to separate file

* Update suggestions

* Regen dev version pulumi@3.203.0-alpha.x821986e

* Reorganize documentation and unify navigation menu (#16119)

* Finally got the menu working

* Breadcrumbs and docs home

* Menus and breadcrumbs lookin good

* refactor: clean up unused partials and styles in documentation layout

* refactor: remove is_overview flag from documentation index files

* Remove generated files from source control

* Remove generated assets from git tracking

* refactor: remove PulumiTV playlists and support section from documentation index

* Layout tweaks

* feat: update documentation layout and styles for improved navigation

* style: adjust navigation styles for improved hover effects and spacing

* review feedback (thanks, Claude!)

* style: remove expanded menu IDs from documentation index files

* New menu structure basically working

* style: remove section headers from documentation index files for consistency

* fix: correct current section for home path and update menu structure

* Moved get started -- AWS working, others not so much

* Get started menu all moved

* feat: add content migration and discovery scripts for documentation restructuring

* Restored top nav

* WIP, moved ESC Get Started, fixed script to move files.

* WIP, moved ESC Get Started, fixed script to move files.

* feat: add comprehensive content migration agent specification for Pulumi documentation

* Reorg Getting Started menu

* Reorg Getting Started menu

* fix: update "Get Started" links to point to the new IaC documentation paths

* fix: update "Get Started" link to correct path in ESC walkthrough note

* fix: simplify breadcrumb logic by removing unnecessary condition

* weights

* Move insights getting started

* fix: correct regex for updating nested menu section in migration script

* Moved "Adopting Pulumi" to "Migrating to Pulumi"

* Moved Download & Install

* Add missing aliases for moved files

Added aliases for 6 moved files to ensure proper URL redirects:
- content/docs/get-started/iac/_index.md
- content/docs/get-started/insights/account-management.md
- content/docs/get-started/insights/add-policies.md
- content/docs/get-started/insights/begin.md
- content/docs/get-started/insights/create-accounts.md
- content/docs/get-started/insights/using-resource-explorer.md

Co-authored-by: Cam Soper <CamSoper@users.noreply.github.com>

* Reorganizing docs architecture (#16074)

* Finally got the menu working

* Breadcrumbs and docs home

* Menus and breadcrumbs lookin good

* refactor: clean up unused partials and styles in documentation layout

* refactor: remove is_overview flag from documentation index files

* Remove generated files from source control

* Remove generated assets from git tracking

* refactor: remove PulumiTV playlists and support section from documentation index

* Layout tweaks

* feat: update documentation layout and styles for improved navigation

* style: adjust navigation styles for improved hover effects and spacing

* review feedback (thanks, Claude!)

* style: remove expanded menu IDs from documentation index files

* New menu structure basically working

* style: remove section headers from documentation index files for consistency

* fix: correct current section for home path and update menu structure

* Moved get started -- AWS working, others not so much

* Get started menu all moved

* feat: add content migration and discovery scripts for documentation restructuring

* Restored top nav

* WIP, moved ESC Get Started, fixed script to move files.

* WIP, moved ESC Get Started, fixed script to move files.

* feat: add comprehensive content migration agent specification for Pulumi documentation

* Reorg Getting Started menu

* Reorg Getting Started menu

* fix: update "Get Started" links to point to the new IaC documentation paths

* fix: update "Get Started" link to correct path in ESC walkthrough note

* fix: simplify breadcrumb logic by removing unnecessary condition

* weights

* Move insights getting started

* fix: correct regex for updating nested menu section in migration script

* Moved "Adopting Pulumi" to "Migrating to Pulumi"

* Moved Download & Install

* Add missing aliases for moved files

Added aliases for 6 moved files to ensure proper URL redirects:
- content/docs/get-started/iac/_index.md
- content/docs/get-started/insights/account-management.md
- content/docs/get-started/insights/add-policies.md
- content/docs/get-started/insights/begin.md
- content/docs/get-started/insights/create-accounts.md
- content/docs/get-started/insights/using-resource-explorer.md

Co-authored-by: Cam Soper <CamSoper@users.noreply.github.com>

---------

Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com>
Co-authored-by: Cam Soper <CamSoper@users.noreply.github.com>

* Moved IDP Get Started

* Update weight for Internal Developer Platform menu item

* Moved Resource Options

* Adjust menu weights for Miscellaneous and State & Backends concepts

* Fix missing trailing slashes in aliases for moved ESC and Insights files

All moved files from the docs reorganization now have proper aliases with trailing slashes as required by the repository guidelines:

- Fixed 8 ESC files: Added trailing slash to aliases pointing to /docs/esc/get-started/* paths
- Fixed 5 Insights files: Added trailing slash to aliases pointing to /docs/insights/get-started/* paths

This ensures proper redirects from old URLs to new locations after the content reorganization.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Cam Soper <CamSoper@users.noreply.github.com>

* Guide section

* Comparisons

* First pass at moving Insights/Policy -- WIP

* lint fix

* Remove unused search and top navigation partials from the documentation layout

* Increase width and max-width of the main content area for better layout on larger screens

* Moved IaC GetStarted back

* Moved ESC get started back

* Moved Insights and IDP Get Starteds back

* More sorting of iac

* Moved neo and copilot

* platform features

* Reorganize platform features section in menu

* Created Admin section

* wip, admin & platform (cloud)

* more WIP

* IaC Guides

* Fixed relref

* Polished Landing Pages

* Landing pages

* Better heading for get started

* Fix title case

* ESC tweaks

* Headers

* Nav menu adjustments & Admin section

* Update header and description for clarity on Pulumi Cloud Platform

* Alias verification script

* Updates to script for repeatability

* Alias fix

* Renamed platforms to deployments

* Menus and breadcrumb fixes

* IaC landing page and some menu tweaks, all pages covered.

* Landing page fixes

* More landing page love

* Insights Cleanup

* Landing page cleanup, new .NET logo

* Work on warnings

* Update menu items to include arrows for SDK documentation links

* Update heading for AI section to 'Infrastructure AI' for clarity

* Rearrange sections in documentation index for better clarity and organization

* Increase maximum width of paragraph in docs home section for improved readability

* Add "Infrastructure as Code" to ancestors and update synonyms in search settings

* Fix expanding CLI menus

* Rename Approvals.md to approvals.md for case consistency

* Update overview label in documentation for consistency

* Update overview link logic in menu and adjust paragraph width in home styles

* Refine .NET documentation for clarity and consistency in language usage

* unneeded agent instruction

* Update tutorials link in menu to use relative path

* Update tutorials heading to include arrow and remove unused section in menu logic

* Add Registry section to documentation and menus for package browsing

* Add visual placeholder for search box in development environment

* Fix style guide violations

- Remove trailing spaces from two content files
- Fix heading capitalization in RBAC docs (H2+ should use sentence case)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Cam Soper <CamSoper@users.noreply.github.com>

---------

Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com>
Co-authored-by: Cam Soper <CamSoper@users.noreply.github.com>
Co-authored-by: Claude <noreply@anthropic.com>

* add task mode details (#16246)

* add task mode details

* claude nits

---------

Co-authored-by: Cam <cam.soper@outlook.com>

* Fix merge conflicts

* Language update

* Update overlay in takeover mode, prevent pointer actions

* Rebase

* Adjust badge per request; add signup default for link

* Add click tracking

---------

Co-authored-by: Pulumi Bot <30351955+pulumi-bot@users.noreply.github.com>
Co-authored-by: Cam Soper <csoper@pulumi.com>
Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com>
Co-authored-by: Cam Soper <CamSoper@users.noreply.github.com>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Mark <mark@pulumi.com>
Co-authored-by: Cam <cam.soper@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants