Implement "Neo Mode" for the marketing site homepage #16247

kimberleyamackenzie · 2025-10-13T23:21:49Z

Add a new toggle on the Marketing site that turns on "Neo mode," which opens a Neo prompt on the homepage that is deeplinked to a Neo query in the console. Note that suggested queries have been updated since below screenshots.

claude · 2025-10-13T23:24:09Z

Pull Request Review: Neo Mode Implementation

I've reviewed PR #16247 implementing Neo Mode for the marketing site homepage. Here are my findings:

Critical Issues

1. Missing newline at end of file (layouts/index.html)

Line: 349 (end of file)
The file must end with a newline character per repository standards (AGENTS.md).

2. Accessibility issues

Lines: Throughout layouts/index.html Neo Mode implementation

The toggle button lacks proper ARIA labels and keyboard accessibility
Suggest adding: aria-label, role, and tabindex attributes
The Neo interface should have aria-hidden when hidden and proper focus management when shown

3. Inline event handlers

Lines: 308, 334 in layouts/index.html
Using inline onclick attributes is not best practice. Consider attaching event handlers via the script block using addEventListener.

4. Hardcoded magic number

Lines: 81, 84 in theme/src/scss/neo-mode.scss
The value 224px appears hardcoded for top position in #neo-interface. This should either be a CSS variable or have a comment explaining what it represents (likely header height).

Style & Documentation Issues

5. Inconsistent spelling

PR description
The description uses deeplinked but the correct spelling should be deep-linked (hyphenated compound adjective).

6. Missing code comments

Lines: 308-349 in layouts/index.html
The JavaScript functions lack documentation comments explaining their purpose and behavior. This would improve maintainability.

7. Generic alt text

Lines: 314, 316 in layouts/index.html
Alt text like toggle on and toggle off could be more descriptive, e.g., Toggle Neo Mode on and Toggle Neo Mode off.

Minor Issues

8. Console error handling

Lines: 335-343 in layouts/index.html
The submitNeoQuery() function doesn't validate the input or provide user feedback if the redirect fails. Consider adding basic validation or error handling.

9. CSS specificity

Lines: Throughout theme/src/scss/neo-mode.scss
Using body #neo-mode-toggle creates unnecessary specificity. Consider using classes instead for better maintainability.

10. Duplicate CSS rules

Lines: 176-197 in theme/src/scss/neo-mode.scss
The .neo-hover-icon styles are duplicated in the neo-active state. This could be refactored to reduce repetition.

Positive Notes

Clean visual implementation with smooth animations
Good use of CSS transitions and transforms
Properly integrates with existing homepage structure
The redirect URL construction is correct

Testing Recommendations

Test keyboard navigation (Tab, Enter, Escape keys)
Test with screen readers
Test on mobile devices (the 215px fixed width may need responsive handling)
Test the deep-link URL to ensure it works correctly in the console
Verify that linting passes: make lint

Summary

The implementation is functionally solid but needs accessibility improvements and minor code quality fixes. The most critical fix is adding the missing newline at EOF. Address the accessibility concerns before merging to ensure the feature is usable by all users.

kimberleyamackenzie · 2025-10-13T23:24:36Z

@vctrfrnndz Here's the first take - I have to implement responsive versions still, but this should be good to review the primary case for any early feedback!

pulumi-bot · 2025-10-13T23:28:54Z

Your site preview for commit e77e6be is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-16247-e77e6bee.s3-website.us-west-2.amazonaws.com.

kimberleyamackenzie · 2025-10-14T01:48:34Z

@vctrfrnndz actually scratch that - i worked on some responsiveness too, so feel free to look/review that as well!

pulumi-bot · 2025-10-14T01:54:59Z

Your site preview for commit 74b5541 is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-16247-74b55412.s3-website.us-west-2.amazonaws.com.

pulumi-bot · 2025-10-14T01:55:04Z

Your site preview for commit 687afed is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-16247-687afeda.s3-website.us-west-2.amazonaws.com.

vctrfrnndz · 2025-10-14T13:17:25Z

Looking good!

Some raw thoughts:

Theres some empty whitespace above the takeover in neo mode, it would be good to tighten
Lets cap the container on the neo content to max-width 800px to force the h2 text to wrap accordingly.
Lets do a tighter line height on the h2.
Placeholder text is too subtle, would bump it to our gray-600 (#757576).
Padding right on the input wrapper should be lower, about 14px.

Mobile

Would switch sooner (same width as the top nav), to the mobile version of the badge
Bump the h2 text in mobile to 2rem.
Make the input text smaller in mobile, about 14px.
For the badge: Would just keep the icon on active state too in mobile

pulumi-bot · 2025-10-14T22:02:11Z

Your site preview for commit 6511212 is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-16247-65112123.s3-website.us-west-2.amazonaws.com.

pulumi-bot · 2025-10-14T22:02:58Z

Your site preview for commit d437857 is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-16247-d4378570.s3-website.us-west-2.amazonaws.com.

pulumi-bot · 2025-10-14T22:03:51Z

Your site preview for commit e59f4f1 is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-16247-e59f4f1b.s3-website.us-west-2.amazonaws.com.

pulumi-bot · 2025-10-14T22:30:52Z

Your site preview for commit 6403068 is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-16247-6403068c.s3-website.us-west-2.amazonaws.com.

pulumi-bot · 2025-10-15T17:45:03Z

Your site preview for commit 824f0c4 is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-16247-824f0c43.s3-website.us-west-2.amazonaws.com.

foot · 2025-10-15T17:59:13Z

theme/src/scss/neo-mode.scss

+body #main-content {
+    transition: opacity 0.3s ease, transform 0.3s ease;
+    max-width: 100vw;
+    overflow-x: hidden;
+}
+
+// Global body styles for Neo mode
+body {
+    overflow-x: hidden;
+    max-width: 100vw;


Is this scoped to neo or more global? We seem to modify body in both main.scss and _marketing too. Which might be a bit confusing sometimes but is a bit of nit.

foot

Very slick 💯 .

Did some testing on saf/ff/chrome and all seems to work great.

pulumi-bot · 2025-10-15T18:46:13Z

Your site preview for commit ab4ff0a is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-16247-ab4ff0a5.s3-website.us-west-2.amazonaws.com.

pulumi-bot · 2025-10-15T22:40:22Z

Your site preview for commit de4486c is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-16247-de4486c6.s3-website.us-west-2.amazonaws.com.

pulumi-bot · 2025-10-16T18:30:19Z

Your site preview for commit 819cde0 is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-16247-819cde0b.s3-website.us-west-2.amazonaws.com.

pulumi-bot · 2025-10-17T19:39:31Z

Your site preview for commit 61d6056 is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-16247-61d6056a.s3-website.us-west-2.amazonaws.com.

pulumi-bot · 2025-10-17T20:00:33Z

Your site preview for commit 4c11364 is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-16247-4c11364d.s3-website.us-west-2.amazonaws.com.

pulumi-bot · 2025-10-17T20:12:43Z

Your site preview for commit b5e3037 is ready! 🎉

http://www-testing-pulumi-docs-origin-pr-16247-b5e3037d.s3-website.us-west-2.amazonaws.com.

kimberleyamackenzie added 3 commits October 13, 2025 13:31

Neo mode first draft

95c28be

Second draft

9c1edaa

Clean up and adjust styles

e77e6be

kimberleyamackenzie temporarily deployed to testing October 13, 2025 23:21 — with GitHub Actions Inactive

kimberleyamackenzie added 2 commits October 13, 2025 18:40

Mobile responsiveness

444e870

Animation

687afed

kimberleyamackenzie temporarily deployed to testing October 14, 2025 01:47 — with GitHub Actions Inactive

kimberleyamackenzie temporarily deployed to testing October 14, 2025 01:48 — with GitHub Actions Inactive

Feedback and suggestion pills draft

e59f4f1

kimberleyamackenzie temporarily deployed to testing October 14, 2025 21:55 — with GitHub Actions Inactive

kimberleyamackenzie force-pushed the km/neo-mode branch from 6511212 to e59f4f1 Compare October 14, 2025 21:56

kimberleyamackenzie temporarily deployed to testing October 14, 2025 21:56 — with GitHub Actions Inactive

kimberleyamackenzie added 2 commits October 14, 2025 15:12

Hide copilot from homepage in favor of Neo takeover

276d137

Move JS to separate file

6e20b65

kimberleyamackenzie force-pushed the km/neo-mode branch from d437857 to 6e20b65 Compare October 14, 2025 22:23

kimberleyamackenzie temporarily deployed to testing October 14, 2025 22:23 — with GitHub Actions Inactive

Merge branch 'master' into km/neo-mode

6403068

kimberleyamackenzie temporarily deployed to testing October 14, 2025 22:23 — with GitHub Actions Inactive

kimberleyamackenzie force-pushed the km/neo-mode branch from 3626f45 to 47b9268 Compare October 15, 2025 17:36

Merge branch 'master' into km/neo-mode

824f0c4

kimberleyamackenzie temporarily deployed to testing October 15, 2025 17:37 — with GitHub Actions Inactive

foot reviewed Oct 15, 2025

View reviewed changes

foot approved these changes Oct 15, 2025

View reviewed changes

Merge branch 'master' into km/neo-mode

b8baea9

kimberleyamackenzie had a problem deploying to testing October 15, 2025 18:20 — with GitHub Actions Failure

Rebase

ab4ff0a

kimberleyamackenzie temporarily deployed to testing October 15, 2025 18:33 — with GitHub Actions Inactive

kimberleyamackenzie temporarily deployed to testing October 15, 2025 22:32 — with GitHub Actions Inactive

Adjust badge per request; add signup default for link

33de2c0

kimberleyamackenzie force-pushed the km/neo-mode branch from de4486c to 33de2c0 Compare October 16, 2025 18:22

Merge branch 'master' into km/neo-mode

819cde0

kimberleyamackenzie temporarily deployed to testing October 16, 2025 18:22 — with GitHub Actions Inactive

Merge branch 'master' into km/neo-mode

61d6056

kimberleyamackenzie temporarily deployed to testing October 17, 2025 19:32 — with GitHub Actions Inactive

Merge branch 'master' into km/neo-mode

4c11364

kimberleyamackenzie temporarily deployed to testing October 17, 2025 19:52 — with GitHub Actions Inactive

Add click tracking

b5e3037

kimberleyamackenzie temporarily deployed to testing October 17, 2025 20:05 — with GitHub Actions Inactive

kimberleyamackenzie merged commit ce2d2f8 into master Oct 17, 2025
8 checks passed

kimberleyamackenzie deleted the km/neo-mode branch October 17, 2025 20:15

kimberleyamackenzie temporarily deployed to testing October 17, 2025 20:15 — with GitHub Actions Inactive

Implement "Neo Mode" for the marketing site homepage #16247

Implement "Neo Mode" for the marketing site homepage #16247

Uh oh!

Conversation

kimberleyamackenzie commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

claude bot commented Oct 13, 2025

Pull Request Review: Neo Mode Implementation

Critical Issues

1. Missing newline at end of file (layouts/index.html)

2. Accessibility issues

3. Inline event handlers

4. Hardcoded magic number

Style & Documentation Issues

5. Inconsistent spelling

6. Missing code comments

7. Generic alt text

Minor Issues

8. Console error handling

9. CSS specificity

10. Duplicate CSS rules

Positive Notes

Testing Recommendations

Summary

Uh oh!

kimberleyamackenzie commented Oct 13, 2025

Uh oh!

pulumi-bot commented Oct 13, 2025

Uh oh!

kimberleyamackenzie commented Oct 14, 2025

Uh oh!

pulumi-bot commented Oct 14, 2025

Uh oh!

pulumi-bot commented Oct 14, 2025

Uh oh!

vctrfrnndz commented Oct 14, 2025 • edited by kimberleyamackenzie Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pulumi-bot commented Oct 14, 2025

Uh oh!

pulumi-bot commented Oct 14, 2025

Uh oh!

pulumi-bot commented Oct 14, 2025

Uh oh!

pulumi-bot commented Oct 14, 2025

Uh oh!

pulumi-bot commented Oct 15, 2025

Uh oh!

foot Oct 15, 2025

Choose a reason for hiding this comment

Uh oh!

foot left a comment

Choose a reason for hiding this comment

Uh oh!

pulumi-bot commented Oct 15, 2025

Uh oh!

pulumi-bot commented Oct 15, 2025

Uh oh!

pulumi-bot commented Oct 16, 2025

Uh oh!

pulumi-bot commented Oct 17, 2025

Uh oh!

pulumi-bot commented Oct 17, 2025

Uh oh!

pulumi-bot commented Oct 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

kimberleyamackenzie commented Oct 13, 2025 •

edited

Loading

vctrfrnndz commented Oct 14, 2025 •

edited by kimberleyamackenzie

Loading