-
Notifications
You must be signed in to change notification settings - Fork 258
Alternative take on pulumi-cloud.md #16532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Update notes shortcode from positional to named parameter syntax - Add missing trailing newline at end of file - Add trailing slash to onboarding guide link for consistency Co-authored-by: Cam Soper <CamSoper@users.noreply.github.com>
…overnance section
…g explanations of features and benefits
Documentation ReviewI've reviewed the changes in this PR. Overall, the writing is tighter and more concise. Here are my findings: Issues Found1. File moved without complete verification (SEO Warning)File: The file has been moved and includes aliases in the frontmatter: aliases:
- /docs/deployments/get-started/what-is-it/
- /docs/pulumi-cloud/get-started/what-is-it/
2. Product name change needs verificationFile: The link text changed from "Pulumi CrossGuard" to "Pulumi Policies" with a different target URL ( - Pulumi Cloud offers organization-wide policies thanks to Pulumi's policy as code engine, [Pulumi CrossGuard](/crossguard/), allowing you to enforce policies
+ Pulumi Cloud offers organization-wide policies thanks to Pulumi's policy as code engine, [Pulumi Policies](/docs/insights/policy/), allowing you to enforce policiesPlease confirm this product name change is intentional and that the new link target is correct. 3. Verify file ends with newlineThe diff was truncated in the output, so I cannot verify the file ends with a newline as required by STYLE-GUIDE.md. Please confirm the file ends with a newline character. Positive Changes
Minor ObservationsFile: The restructuring of the concepts index page looks good. The new layout places "Pulumi Cloud" prominently after "How Pulumi works" which makes logical sense for new users. File: The shortcode path update from Summary
The changes improve readability and content organization. The main items to verify are the product name change and running the alias verification script post-merge. Mention me (@claude) if you'd like me to review any revisions or need help with fixes! |
|
Your site preview for commit 05e927d is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16532-05e927db.s3-website.us-west-2.amazonaws.com. |
joeduffy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🚀
Less cut down, still tightened prose.
Also fixes #16517