Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ABS bot sample #464

Merged
merged 7 commits into from Nov 18, 2019
Merged

ABS bot sample #464

merged 7 commits into from Nov 18, 2019

Conversation

daltskin
Copy link
Contributor

@daltskin daltskin commented Nov 17, 2019

Address #463

@stack72 stack72 requested a review from mikhailshilkov Nov 17, 2019
Copy link
Collaborator

@mikhailshilkov mikhailshilkov left a comment

This looks great! I'll try it out tomorrow. I left some comments here and there. Thanks a lot for contributing!

azure-cs-botservice/Azure.BotService.csproj Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
azure-cs-botservice/Azure.BotService.sln Outdated Show resolved Hide resolved
azure-cs-botservice/Program.cs Outdated Show resolved Hide resolved
azure-cs-botservice/Pulumi.yaml Outdated Show resolved Hide resolved
azure-cs-botservice/Program.cs Outdated Show resolved Hide resolved
azure-cs-botservice/Program.cs Outdated Show resolved Hide resolved
azure-cs-botservice/Program.cs Outdated Show resolved Hide resolved
azure-cs-botservice/README.md Outdated Show resolved Hide resolved
@daltskin
Copy link
Contributor Author

@daltskin daltskin commented Nov 17, 2019

All good feedback, let me action.

Copy link
Collaborator

@mikhailshilkov mikhailshilkov left a comment

This is great, I was able to deploy the bot! Left a couple comments, LGTM otherwise. Thank you!

azure-cs-botservice/Program.cs Outdated Show resolved Hide resolved
azure-cs-botservice/Program.cs Outdated Show resolved Hide resolved
azure-cs-botservice/README.md Outdated Show resolved Hide resolved
azure-cs-botservice/Program.cs Outdated Show resolved Hide resolved
azure-cs-botservice/Program.cs Outdated Show resolved Hide resolved
Copy link
Collaborator

@mikhailshilkov mikhailshilkov left a comment

I had one final question and then I'm ready to merge

{
ApplicationInsightsId = appInsights.Id,
ReadPermissions = "api",
});

var luis = new Pulumi.Azure.Cognitive.Account("cs", new Pulumi.Azure.Cognitive.AccountArgs
var luis = new Account("cs", new AccountArgs
Copy link
Collaborator

@mikhailshilkov mikhailshilkov Nov 18, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also qualify this Account with a namespace? (Cognitive.Account)

@mikhailshilkov
Copy link
Collaborator

@mikhailshilkov mikhailshilkov commented Nov 18, 2019

Thanks for contributing, @daltskin! Great work!

@mikhailshilkov mikhailshilkov merged commit 1fcae28 into pulumi:master Nov 18, 2019
1 check failed
dixler pushed a commit that referenced this issue Jan 21, 2022
* ABS bot sample

* clean up code

* Address comments

* Add the sample bot source code, so others can easily modify

* Bring in some namespaces - highlight which folders to run CLI from

* Parenthesis not required.

* use Cognitive alias
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants