Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ABS bot sample #464

Merged
merged 7 commits into from Nov 18, 2019
Merged

ABS bot sample #464

merged 7 commits into from Nov 18, 2019

Conversation

@daltskin
Copy link
Contributor

daltskin commented Nov 17, 2019

Address #463

@stack72 stack72 requested a review from mikhailshilkov Nov 17, 2019
Copy link
Collaborator

mikhailshilkov left a comment

This looks great! I'll try it out tomorrow. I left some comments here and there. Thanks a lot for contributing!

azure-cs-botservice/Azure.BotService.csproj Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
azure-cs-botservice/Azure.BotService.sln Outdated Show resolved Hide resolved
azure-cs-botservice/Program.cs Outdated Show resolved Hide resolved
azure-cs-botservice/Pulumi.yaml Outdated Show resolved Hide resolved
azure-cs-botservice/Program.cs Outdated Show resolved Hide resolved
azure-cs-botservice/Program.cs Outdated Show resolved Hide resolved
azure-cs-botservice/Program.cs Outdated Show resolved Hide resolved
azure-cs-botservice/README.md Outdated Show resolved Hide resolved
@daltskin

This comment has been minimized.

Copy link
Contributor Author

daltskin commented Nov 17, 2019

All good feedback, let me action.

Copy link
Collaborator

mikhailshilkov left a comment

This is great, I was able to deploy the bot! Left a couple comments, LGTM otherwise. Thank you!

azure-cs-botservice/Program.cs Outdated Show resolved Hide resolved
azure-cs-botservice/Program.cs Outdated Show resolved Hide resolved
azure-cs-botservice/README.md Outdated Show resolved Hide resolved
azure-cs-botservice/Program.cs Outdated Show resolved Hide resolved
azure-cs-botservice/Program.cs Outdated Show resolved Hide resolved
Copy link
Collaborator

mikhailshilkov left a comment

I had one final question and then I'm ready to merge

{
ApplicationInsightsId = appInsights.Id,
ReadPermissions = "api",
});

var luis = new Pulumi.Azure.Cognitive.Account("cs", new Pulumi.Azure.Cognitive.AccountArgs
var luis = new Account("cs", new AccountArgs

This comment has been minimized.

Copy link
@mikhailshilkov

mikhailshilkov Nov 18, 2019

Collaborator

Should we also qualify this Account with a namespace? (Cognitive.Account)

@mikhailshilkov

This comment has been minimized.

Copy link
Collaborator

mikhailshilkov commented Nov 18, 2019

Thanks for contributing, @daltskin! Great work!

@mikhailshilkov mikhailshilkov merged commit 1fcae28 into pulumi:master Nov 18, 2019
1 check failed
1 check failed
Travis CI - Pull Request Build Errored
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.