ABS bot sample#464
Merged
Merged
Conversation
Contributor
Author
|
All good feedback, let me action. |
mikhailshilkov
approved these changes
Nov 18, 2019
Contributor
mikhailshilkov
left a comment
mikhailshilkov
left a comment
There was a problem hiding this comment.
This is great, I was able to deploy the bot! Left a couple comments, LGTM otherwise. Thank you!
mikhailshilkov
approved these changes
Nov 18, 2019
Contributor
mikhailshilkov
left a comment
mikhailshilkov
left a comment
There was a problem hiding this comment.
I had one final question and then I'm ready to merge
| }); | ||
|
|
||
| var luis = new Pulumi.Azure.Cognitive.Account("cs", new Pulumi.Azure.Cognitive.AccountArgs | ||
| var luis = new Account("cs", new AccountArgs |
Contributor
There was a problem hiding this comment.
Should we also qualify this Account with a namespace? (Cognitive.Account)
Contributor
|
Thanks for contributing, @daltskin! Great work! |
dixler
pushed a commit
that referenced
this pull request
Jan 21, 2022
* ABS bot sample * clean up code * Address comments * Add the sample bot source code, so others can easily modify * Bring in some namespaces - highlight which folders to run CLI from * Parenthesis not required. * use Cognitive alias
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address #463