New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ABS bot sample #464

Merged

mikhailshilkov merged 7 commits into pulumi:master from daltskin:master

Nov 18, 2019

Contributor

daltskin commented Nov 17, 2019

Address #463


          ABS bot sample

stack72 requested a review from mikhailshilkov

November 17, 2019 19:25


          clean up code

35c4d8b

mikhailshilkov reviewed

View reviewed changes

Member

mikhailshilkov left a comment •

edited

Loading

This looks great! I'll try it out tomorrow. I left some comments here and there. Thanks a lot for contributing!

azure-cs-botservice/Azure.BotService.csproj Outdated Show resolved Hide resolved

CONTRIBUTING.md Show resolved Hide resolved

azure-cs-botservice/Azure.BotService.sln Outdated Show resolved Hide resolved

azure-cs-botservice/Program.cs Outdated Show resolved Hide resolved

azure-cs-botservice/Pulumi.yaml Outdated Show resolved Hide resolved

azure-cs-botservice/Program.cs Outdated Show resolved Hide resolved

azure-cs-botservice/Program.cs Outdated Show resolved Hide resolved

azure-cs-botservice/Program.cs Outdated Show resolved Hide resolved

azure-cs-botservice/README.md Outdated Show resolved Hide resolved

Contributor Author

daltskin commented Nov 17, 2019

All good feedback, let me action.

daltskin added 2 commits

November 17, 2019 21:41


          Address comments

c6043d0


          Add the sample bot source code, so others can easily modify

68df599

mikhailshilkov approved these changes

View reviewed changes

Member

mikhailshilkov left a comment

This is great, I was able to deploy the bot! Left a couple comments, LGTM otherwise. Thank you!

azure-cs-botservice/Program.cs Outdated Show resolved Hide resolved

azure-cs-botservice/Program.cs Outdated Show resolved Hide resolved

azure-cs-botservice/README.md Outdated Show resolved Hide resolved

azure-cs-botservice/Program.cs Outdated Show resolved Hide resolved

azure-cs-botservice/Program.cs Outdated Show resolved Hide resolved

daltskin added 2 commits

November 18, 2019 10:26


          Bring in some namespaces - highlight which folders to run CLI from

d449200


          Parenthesis not required.

00070ad

mikhailshilkov approved these changes

View reviewed changes

Member

mikhailshilkov left a comment

I had one final question and then I'm ready to merge

azure-cs-botservice/Program.cs Outdated

                           {
                               ApplicationInsightsId = appInsights.Id,
                               ReadPermissions = "api",
                           });
-                          var luis = new Pulumi.Azure.Cognitive.Account("cs", new Pulumi.Azure.Cognitive.AccountArgs
+                          var luis = new Account("cs", new AccountArgs

Member

mikhailshilkov Nov 18, 2019

Should we also qualify this Account with a namespace? (Cognitive.Account)


          use Cognitive alias

3ef3235

Member

mikhailshilkov commented Nov 18, 2019

Thanks for contributing, @daltskin! Great work!

mikhailshilkov merged commit 1fcae28 into pulumi:master

pgavlin mentioned this pull request

Missing Azure Bot Service example #463

Closed

dixler pushed a commit that referenced this pull request


          ABS bot sample (#464)

9349a70

* ABS bot sample

* clean up code

* Address comments

* Add the sample bot source code, so others can easily modify

* Bring in some namespaces - highlight which folders to run CLI from

* Parenthesis not required.

* use Cognitive alias

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet