Setting Provider defaults to remove slow calls to AWS STS and Metadata #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #873 * `skipCredentialsValidation` now defaults to `true`. * `skipGetEc2Platforms` now defaults to `true`. * `skipMetadataApiCheck` now defaults to `true`. * `skipRegionValidation` now defaults to `true`.
|
Was #873 introduced at some point or was it always like that? What does TF default to? Any downsides to new defaults?
Do you know why we can it twice? Does this change eliminate both? |
So #873 is a long standing issue due to upstream - we re trying to diverge from the TF provider by changing these defaults. |
leezen
approved these changes
Feb 5, 2021
t0yv0
added a commit
that referenced
this pull request
May 22, 2024
This PR explores reverting the default `aws:skipMetadataApiCheck=false` setting to enable the provider to be able to seamlessly authenticate against an IMDS(v2) endpoints in the AWS environment. It appears that doing so no longer slows down the provider startup time perceptibly. The way I tested the speed delta was by measuring local empty preview of an AWS s3 Bucket using AWS_PROFILE authentication with local <-> us-east-1 there is no perceptible difference. Fixes: #1692 An integration test is added that exercises `pulumi preview` on an EC2 instance with IMDSv2 and asserts that the provider can authenticate successfully. Background: - #873 - #1288
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #873
skipCredentialsValidationnow defaults totrue.skipGetEc2Platformsnow defaults totrue.skipMetadataApiChecknow defaults totrue.skipRegionValidationnow defaults totrue.It's important to note that this does not require the replacement of either default or named provider: