Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set user-provided tags on all created sub-resources #383

Open
ringods opened this issue Aug 10, 2019 · 3 comments

Comments

@ringods
Copy link

commented Aug 10, 2019

Pulumi Crosswalk for AWS provides a set of components, which are a composite of the individual pulumi-aws resources. For a composite component, please make sure that user-provided AWS tags are set on all the contained individual components.

For instance, an awsx.ec2.Vpc (possibly) creates a VPC, subnets, routing tables, internet gateways, NAT gateways, ... The tags passed into the parent component only seem to be set on the VPC at the moment, not on the subnets and other resources.

For the VPC example, setting specific tags can be required for Kubernetes as was asked by Scott Lowe on the Pulumi Community Slack.

For AWS Cost Reporting based on tags, all resources should receive the tags. To report on the cost of a subset of resources within an AWS account, I use the tags project and environment consistently. Now I can see what my development, staging and production environments cost me per project.

Context:

  • Could be a duplicate of #209, but that ticket only contains a title.
  • Related to #161, #306 & #322
@CyrusNajmabadi

This comment has been minimized.

Copy link
Contributor

commented Aug 12, 2019

@ringods This is indeed an area we want to create a solution for. However, we don't necessarily think the right approach is to just take the tags and apply to all sub-resources. It may be about providing a more flexibly approach where you get the chance to participate in resource construction and can decide on a per-resource basis precisely what tweaks you want to make.

We'll let you now as we start work in this area to ensure any solution will be viable for you :)

@CyrusNajmabadi CyrusNajmabadi self-assigned this Aug 12, 2019

@ringods

This comment has been minimized.

Copy link
Author

commented Aug 15, 2019

@CyrusNajmabadi having a (for me) standard set of tags on all resources is all I need for AWS cost reporting. So please do not over-engineer this. My use case is simple.

@CyrusNajmabadi

This comment has been minimized.

Copy link
Contributor

commented Aug 20, 2019

@ringods Thanks for clarifying your use case. We def want to make sure that you can have a solution that works for you. However, we also need to be cognizant of feedback we've heard from otehrs where tagging is important and it's not the case that all teh resources get the exact same set of tags. It would be a pity to add a solutoin only to have it have to be replaced with a different solution later to meet the needs of others in a similar, but not exactly the same, situation as you. Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.