Refactor client to accept TLS connections #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guineveresaenger
requested review from
AaronFriel,
jazzyfresh,
aureq and
a team
Does the PR have any schema changes?Looking good! No breaking changes found. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
aureq
reviewed
Mar 28, 2023
|
@guineveresaenger Let me know if my 2 comments make sense and if you'd like to discuss them. But overall, this is an awesome work! Can't wait to test it. |
Does the PR have any schema changes?Looking good! No breaking changes found. |
jazzyfresh
approved these changes
Mar 28, 2023
Does the PR have any schema changes?Looking good! No breaking changes found. |
aureq
reviewed
Mar 28, 2023
There was a problem hiding this comment.
I think @jazzyfresh has raised some excellent points throughout the PR. Everything else looks good to me.
Co-authored-by: Jasmine Dahilig <jasmine@pulumi.com>
Does the PR have any schema changes?Looking good! No breaking changes found. |
1 similar comment
Does the PR have any schema changes?Looking good! No breaking changes found. |
aureq
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #533.
This pull request reads in configuration from the stack config into the native provider part of the Docker provider.
It forwards these values to the Image resource, and uses them to configure a Docker client with the capability of accepting TLS configuration settings as defined in the schema.
The code verifies that the settings exist, and it instantiates a custom client if they do. Prior art for this logic is implemented in the upstream provider.