fix(nodeSecurityGroupTags): only expose option through Cluster class #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metral
changed the title
metral
added a commit
that referenced
this pull request
May 3, 2019
metral
commented
May 3, 2019
metral
commented
May 3, 2019
metral
force-pushed
the
metral/fix-nodeSecurityGroupTags
branch
from
908859e
to
2b5409b
Compare
metral
added a commit
that referenced
this pull request
May 3, 2019
lukehoban
approved these changes
May 8, 2019
nodejs/eks/nodegroup.ts
Outdated
| * | ||
| * Note: If you want to tag this `nodeSecurityGroup`, you must manually | ||
| * tag it during its external creation, before it is used in this node | ||
| * group. |
There was a problem hiding this comment.
Perhaps phrase this as nodeSecurityGroup and nodeSecurityGroupTags are mutually exclusive? We could also test that at most one is set and error.
There was a problem hiding this comment.
@lukehoban both the option comment, and the mutual exclusion check have been addressed. PTAL
metral
force-pushed
the
metral/fix-nodeSecurityGroupTags
branch
from
2b5409b
to
aad56f0
Compare
metral
added a commit
that referenced
this pull request
May 9, 2019
metral
force-pushed
the
metral/fix-nodeSecurityGroupTags
branch
from
aad56f0
to
c1cd2c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #125.
Related #122.
Update for the new tag opts (based on orig in #122):
Clusterclass:.tags- A map of tags that is applied to all AWS resources under management by apulumi/ekscluster. Currently applied to:eksClusterSecurityGroup,nodeSecurityGroup, the Worker AutoScalingGroup (ASG), and cloudFormation stack..clusterSecurityGroupTags- A map of tags applied to the EKS Cluster security group.nodeSecurityGroupTags- A map of tags applied to the Worker Nodes security groupNodeGroupclass:.cloudFormationTags- A map of tags applied to the CloudFormation Stack of Worker Nodes.autoScalingGroupTags- A map of tags applied to the Worker NodeGroup ASG & InstancesnodeSecurityGroup, you can tag it by manually setting the tags during its external creation, and before it is used in the NodeGroup.