Add a Cloud Function example #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viveklak
reviewed
Apr 8, 2021
| } | ||
| count++ | ||
| // delay 10s, 20s, then 30s and stay at 30s | ||
| if sleep > 30 { |
There was a problem hiding this comment.
Maybe just replace with "github.com/jpillora/backoff" as we do in the provider?
There was a problem hiding this comment.
I copied this 1:1 from the examples repo. We could improve both I guess.
viveklak
reviewed
Apr 8, 2021
provider/pkg/provider/provider.go
Outdated
| @@ -510,7 +510,7 @@ func (k *googleCloudProvider) Delete(ctx context.Context, req *rpc.DeleteRequest | |||
| } | |||
|
|
|||
| id := req.GetId() | |||
| uri := fmt.Sprintf("%s/%s", res.BaseUrl, id) | |||
| uri := fmt.Sprintf("%s%s", res.BaseUrl, id) | |||
There was a problem hiding this comment.
Perhaps just use this?
Suggested change
| uri := fmt.Sprintf("%s%s", res.BaseUrl, id) | |
| uri := path.Join(res.BaseUrl, id) |
There was a problem hiding this comment.
It turns out path.Join doesn't quite work for URLs with all kinds of weirdness re-encoding the strings. I refactored this to a function on the resource and made some extra slashes trimmed just in case.
viveklak
approved these changes
Apr 8, 2021
mikhailshilkov
force-pushed
the
mikhailshilkov/function-example
branch
from
f504a2c
to
6216c14
Compare
mikhailshilkov
force-pushed
the
mikhailshilkov/function-example
branch
from
6216c14
to
916a9ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, fixes the DELETE for storage bucket/object