Add unstructured converter and test fixtures #446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lblackstone
added
the
impact/no-changelog-required
metral
approved these changes
Feb 23, 2019
| } | ||
|
|
||
| var output metav1.Object | ||
| switch kinds.Kind(obj.GetKind()) { |
There was a problem hiding this comment.
Can we have docs stating which objects are supported today vs not?
There was a problem hiding this comment.
Yeah, I'll add docs eventually, but for right now, this is the set of objects we're using the in complex await logic.
| "k8s.io/apimachinery/pkg/apis/meta/v1/unstructured" | ||
| ) | ||
|
|
||
| func TestFromUnstructured(t *testing.T) { |
There was a problem hiding this comment.
Are there plans to test the rest of the supported objects other than the Pod and Deployment?
There was a problem hiding this comment.
Yeah, probably should have been more clear in the description, but this PR is basically a prototype to make sure the approach made sense before I fully committed to it. My intent is to expand these fixtures to replace all the giant YAML strings in the unit tests. I'll keep fleshing things out over multiple PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.