Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python wheel installs a top-level package called "test" #2888

Closed
pganssle opened this issue Jun 29, 2019 · 0 comments · Fixed by #3067

Comments

@pganssle
Copy link

commented Jun 29, 2019

The current setup.py for the Python SDK is misconfigured, as it is using find_packages() while the test folder is a proper package with an __init__.py. The safest thing to do is to switch to a src/ layout, but you can also mitigate the problem by using a whitelist of included top-level packages in your find_packages.

You may want to add some kind of test to your CI or release process to ensure that you don't end up installing a package called test or tests as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.