Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple testproj module names detected #6775

Closed
Volatus opened this issue Apr 14, 2021 · 2 comments · Fixed by #6800
Closed

Multiple testproj module names detected #6775

Volatus opened this issue Apr 14, 2021 · 2 comments · Fixed by #6800
Labels
good-first-issue Start here if you'd like to start contributing to Pulumi kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed

Comments

@Volatus
Copy link
Contributor

Volatus commented Apr 14, 2021

VS Code with the Go extension reports issues regarding testproj module being found more than once.

Expected behavior

There should be no errors.

Current behavior

The Gopls language server has some issues with the go modules within the Pulumi repository. Supposedly it's due to a module being found twice within the workspace.

Steps to reproduce

  1. Fork & Clone Pulumi
  2. Make sure you have Go extension installed in VS Code
  3. Make sure all dependencies are present and run make ensure (For me it's present even before the make command)

image

Context (Environment)

There have been no changes made to the code but this errors shows up with the repository from upstream.

Affected feature
@Volatus Volatus added the kind/bug Some behavior is incorrect or out of spec label Apr 14, 2021
@leezen
Copy link
Contributor

leezen commented Apr 15, 2021

@Selonophile These conflicts show up as multiple tests end up using the same module name, but this shouldn't affect anything in the actual build of the repo itself.

Not sure if others are bothered by this. Happy to take a PR to make these test project names unique.

@leezen leezen added kind/engineering Work that is not visible to an external user and removed kind/bug Some behavior is incorrect or out of spec labels Apr 15, 2021
@leezen leezen changed the title Issues with development environment in VS Code Multiple testproj package names detected Apr 15, 2021
@leezen leezen changed the title Multiple testproj package names detected Multiple testproj module names detected Apr 15, 2021
@leezen leezen added the good-first-issue Start here if you'd like to start contributing to Pulumi label Apr 15, 2021
@Volatus Volatus mentioned this issue Apr 17, 2021
Merged
@Volatus
Copy link
Contributor Author

Volatus commented Apr 17, 2021

@leezen Just opened the PR for this.

komalali pushed a commit that referenced this issue Apr 19, 2021
@Volatus
Fixes #6775: Duplicated Go modules (#6800)
4bafeee
@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Apr 19, 2021
abhinav pushed a commit to pulumi/pulumi-dotnet that referenced this issue Jan 11, 2023
@Volatus
Fixes pulumi/pulumi#6775: Duplicated Go modules (pulumi/pulumi#6800)
11c2cca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue Start here if you'd like to start contributing to Pulumi kind/engineering Work that is not visible to an external user resolution/fixed This issue was fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #6775: Duplicated Go modules
3 participants
@leezen @pulumi-bot @Volatus