Issue a better error message if you capture a V8 intrinsic #1423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindydonna
approved these changes
May 23, 2018
|
thanks! |
chrsmith
pushed a commit
that referenced
this pull request
May 27, 2018
lindydonna
added
kind/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1400.
The TypeScript compiler (correctly) rejects V8 intrinsics as being invalid identifiers, which caused us to throw an exception when trying to closure serialize a function that uses one. Instead of throwing an exception, this PR issues an error message through the usual closure serialization scheme so that users can see the full stack of functions that ultimately closed over an intrinsic.