Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python FileAsset to accept os.PathLike in addition to str. #3368

Merged
merged 3 commits into from
Oct 18, 2019

Conversation

campbellr
Copy link
Contributor

This should fix #2896.

For the record I'm not very familiar with the codebase and it wasn't entirely clear to me what the tests are actually doing, so if the test changes I made are insufficient I'd be happy to fix them.

Copy link
Member

@lukehoban lukehoban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This overall looks good to me. PRs from forks don’t currently run the full test suite - so if you’ve already run the python sdk tests locally - feel free to add output here - else I’ll pull into a branch where we can get a Travis test run.

sdk/python/lib/pulumi/asset.py Outdated Show resolved Hide resolved
@campbellr
Copy link
Contributor Author

I was having issues running the entire suite of pulumi tests (make travis_pull_request from the root of the repo), but I did manage to run all the python sdk tests.

Here's the results of make build test_all in sdk/python:

test_output.txt

@pgavlin
Copy link
Member

pgavlin commented Oct 18, 2019

Running a buddy build of the tests now.

@pgavlin
Copy link
Member

pgavlin commented Oct 18, 2019

We're good. Going to go ahead and merge after resolving conflicts.

@pgavlin pgavlin merged commit 665b4ca into pulumi:master Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support pathlib.Path in FileAsset
3 participants