Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update python FileAsset to accept os.PathLike in addition to str. #3368

Merged
merged 3 commits into from Oct 18, 2019

Conversation

@campbellr
Copy link
Contributor

campbellr commented Oct 18, 2019

This should fix #2896.

For the record I'm not very familiar with the codebase and it wasn't entirely clear to me what the tests are actually doing, so if the test changes I made are insufficient I'd be happy to fix them.

@campbellr campbellr force-pushed the campbellr:issue-2896 branch from 0e5a337 to f74532f Oct 18, 2019
Copy link
Member

lukehoban left a comment

Thanks! This overall looks good to me. PRs from forks don’t currently run the full test suite - so if you’ve already run the python sdk tests locally - feel free to add output here - else I’ll pull into a branch where we can get a Travis test run.

sdk/python/lib/pulumi/asset.py Outdated Show resolved Hide resolved
@campbellr campbellr force-pushed the campbellr:issue-2896 branch from f74532f to b7b942d Oct 18, 2019
@campbellr

This comment has been minimized.

Copy link
Contributor Author

campbellr commented Oct 18, 2019

I was having issues running the entire suite of pulumi tests (make travis_pull_request from the root of the repo), but I did manage to run all the python sdk tests.

Here's the results of make build test_all in sdk/python:

test_output.txt

@pgavlin

This comment has been minimized.

Copy link
Member

pgavlin commented Oct 18, 2019

Running a buddy build of the tests now.

@pgavlin

This comment has been minimized.

Copy link
Member

pgavlin commented Oct 18, 2019

We're good. Going to go ahead and merge after resolving conflicts.

@pgavlin pgavlin merged commit 665b4ca into pulumi:master Oct 18, 2019
1 of 3 checks passed
1 of 3 checks passed
Travis CI - Pull Request Build Errored
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
Update Changelog Please update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.