New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests for .NET aliases #3420
Tests for .NET aliases #3420
Conversation
tests/integration/aliases/dotnet/adopt_into_component/step2/Program.cs
Outdated
Show resolved
Hide resolved
I'll look into what's going wrong here. thanks for writing the tests! |
tests/integration/aliases/dotnet/adopt_into_component/step2/Program.cs
Outdated
Show resolved
Hide resolved
Ok. investigating why this is failing. |
b9151ae
to
07c0f86
Compare
{ | ||
/// <summary> | ||
/// Computes a URN from the combination of a resource name, resource type, optional parent, | ||
/// optional project and optional stack. | ||
/// </summary> | ||
/// <returns></returns> | ||
internal static Output<string> Create( | ||
public static Output<string> Create( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exposed this method to use it in one of the tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any other way to consume this from the test without exposing the method?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our integration tests are just Pulumi programs, so I don't think so... FWIW, the same method is exposed in the Node.js SDK too.
@CyrusNajmabadi I fixed the existing and included the missing tests. Ready for review! Well done fixing it! |
a1b63e8
to
00ce374
Compare
00ce374
to
a1b63e8
Compare
a1b63e8
to
6795c8e
Compare
Tests for .NET aliases
Adding tests for aliases in .NET - both tests fail. Aliases not working yet? @CyrusNajmabadi