Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for .NET aliases #3420

Merged
merged 3 commits into from Nov 20, 2019
Merged

Conversation

mikhailshilkov
Copy link
Member

Adding tests for aliases in .NET - both tests fail. Aliases not working yet? @CyrusNajmabadi

@CyrusNajmabadi
Copy link
Contributor

I'll look into what's going wrong here. thanks for writing the tests!

@CyrusNajmabadi CyrusNajmabadi added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Nov 5, 2019
@CyrusNajmabadi
Copy link
Contributor

Ok. investigating why this is failing.

@mikhailshilkov mikhailshilkov force-pushed the mikhailshilkov/dotnet-aliases-tests branch from b9151ae to 07c0f86 Compare November 11, 2019 09:56
@mikhailshilkov mikhailshilkov changed the title [WIP] Tests for .NET aliases Tests for .NET aliases Nov 11, 2019
{
/// <summary>
/// Computes a URN from the combination of a resource name, resource type, optional parent,
/// optional project and optional stack.
/// </summary>
/// <returns></returns>
internal static Output<string> Create(
public static Output<string> Create(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exposed this method to use it in one of the tests

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any other way to consume this from the test without exposing the method?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our integration tests are just Pulumi programs, so I don't think so... FWIW, the same method is exposed in the Node.js SDK too.

@mikhailshilkov
Copy link
Member Author

mikhailshilkov commented Nov 11, 2019

@CyrusNajmabadi I fixed the existing and included the missing tests. Ready for review! Well done fixing it!

@lukehoban lukehoban mentioned this pull request Nov 15, 2019
38 tasks
@mikhailshilkov mikhailshilkov force-pushed the mikhailshilkov/dotnet-aliases-tests branch from a1b63e8 to 00ce374 Compare November 20, 2019 06:09
@mikhailshilkov mikhailshilkov force-pushed the mikhailshilkov/dotnet-aliases-tests branch from 00ce374 to a1b63e8 Compare November 20, 2019 06:11
@mikhailshilkov mikhailshilkov force-pushed the mikhailshilkov/dotnet-aliases-tests branch from a1b63e8 to 6795c8e Compare November 20, 2019 06:13
@mikhailshilkov mikhailshilkov merged commit 6f55e1a into master Nov 20, 2019
@pulumi-bot pulumi-bot deleted the mikhailshilkov/dotnet-aliases-tests branch November 20, 2019 19:08
abhinav pushed a commit to pulumi/pulumi-dotnet that referenced this pull request Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants