Update grpc package to 1.24.2 for js sdk #3512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c2h5oh
force-pushed
the
master
branch
3 times, most recently
from
ee1a31b
to
bb41430
Compare
c2h5oh
changed the title
Fixes building grpc package with gcc8 and newer Fixes building grpc package for node 13.x Matches minor grpc release (1.24.x) to version used by dotnet sdk
|
Thanks, @c2h5oh! In order to get CI coverage on this, I am going to open an equivalent PR. If that PR passes CI, we'll merge this. |
|
Any updates on this? |
|
Disregard that--I do see some tests failing. Investigating now. |
|
Okay, we're good. The test failures were transient. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes building grpc package with gcc8 and newer
Fixes building grpc package for node 13.x
Matches minor gprc release (1.24.x) to version used by dotnet sdk