Propagate parent and providers for go SDK calls #3563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgavlin
requested changes
Nov 25, 2019
sdk/go/pulumi/context.go
Outdated
| @@ -531,6 +617,13 @@ func (ctx *Context) getOpts(opts ...ResourceOpt) (URN, []URN, bool, string, bool | |||
| } | |||
| } | |||
|
|
|||
| providers := mergeProviders(t, opts...) | |||
There was a problem hiding this comment.
Feels like we should just pull this off of *ResourceState rather than recomputing it.
There was a problem hiding this comment.
Done. Thanks for pointing this out. I imagine the concern here is perf related, as piping through the additional parameter through two functions is a little ugly? Looking more closely, we're computing a set of sync and async properties, and we should probably have prepareOpts functions for each to make this a little cleaner.
There was a problem hiding this comment.
(It's been a minute since I had to worry at object allocation level perf, so I appreciate helping me get up to speed here.)
…oSDKParentSupport
pgavlin
approved these changes
Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3494
I added support to propagate a parent in
Invokecalls. If specified, parent is used as a backstop to lookup providers for the operation.While I was in this space, I also did the same for
RegisterResource, andReadResource.ReadResourcehas a bug in the API that is blocking me from writing the proper tests #3562. I'll be addressing that bug and adding the appropriate tests in another PR.I had to update the version of
assertin order to useassert.Sameto verify pointer equality.