improve dev version detection #4732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the `isDevVersion` function only tests for "dev" versions. When installing pulumi from Homebrew with the `--HEAD` flag we get an alpha version locally. This can mean the user gets the upgrade prompt when it's not valid. This change changes the logic to check against a regex for all the possible semver `pre` versions. It also adds a unit test to ensure we're getting the right result
jaxxstorm
force-pushed
the
jaxxstorm/fix-dev-version
branch
from
ee94c8c
to
a6ecd5c
Compare
Co-authored-by: Justin Van Patten <jvp@justinvp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
isDevVersionfunction only tests for "dev" versions.When installing pulumi from Homebrew with the
--HEADflag we get analpha version locally. This can mean the user gets the upgrade prompt
when it's not valid.
This change changes the logic to check against a regex for all the
possible semver
preversions.It also adds a unit test to ensure we're getting the right result