Enable SourceLink with embedded PDB #4967
Conversation
|
@mikhailshilkov I don't have a full development environment yet, pending the vs code dev container, so I didn't do a full build, just enough to verify the two
I also bumped the .NET SDK to current latest since it helps with the build order when embedding untracked sources. |
| @@ -10,7 +10,7 @@ jobs: | |||
| go-version: [1.14.x] | |||
| node-version: [10.x] | |||
| python-version: [3.7] | |||
| dotnet: ['3.1.100'] | |||
| dotnet: ['3.1.301'] | |||
There was a problem hiding this comment.
@stack72 @jaxxstorm any objections against this change?
There was a problem hiding this comment.
Not from me - if you are happy with the new version being correct then we can roll that out everywhere
There was a problem hiding this comment.
See my comment above for why I bumped the .NET SDK.
There was a problem hiding this comment.
@stack72 Which versions are we using "everywhere" now? Could you link to the place where it's configured?
There was a problem hiding this comment.
There was a problem hiding this comment.
In all of the providers (from a private repo) the version we have configured is
dotnetversion: ['3.1.201'],
There was a problem hiding this comment.
@mikhailshilkov I just did a manual test and I can confirm I could step debug into Pulumi source from my program.
Fixes #4962.