Add the ability to set the passphrase secrets provider to read from a passphrase file #5327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinvp
approved these changes
Sep 11, 2020
There was a problem hiding this comment.
LGTM otherwise.
Also, mind opening a PR in the docs repo to add the new environment variable to the docs? https://github.com/pulumi/docs/blob/master/content/docs/reference/cli/environment-variables.md
| if err != nil { | ||
| return "", errors.New("unable to construct a path the PULUMI_CONFIG_PASSPHRASE_FILE") | ||
| } | ||
| phraseDetails, err := ioutil.ReadFile(phraseFilePath) |
There was a problem hiding this comment.
What if the file has trailing newlines? I assume we do not want to treat that as part of the passphrase.
Maybe do it like how we read from the console elsewhere (which can be from a file via redirected std input)?
pulumi/sdk/go/common/util/cmdutil/console.go
Lines 72 to 78 in 848a98d
stack72
force-pushed
the
stack72/gh-5305
branch
from
31743fa
to
4a36c43
Compare
justinvp
reviewed
Sep 11, 2020
stack72
force-pushed
the
stack72/gh-5305
branch
from
4a36c43
to
b58b0ac
Compare
stack72
force-pushed
the
stack72/gh-5305
branch
from
b58b0ac
to
b8405d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5305
https://asciinema.org/a/INd7fs6nALeuKgxusIxr73VHk