[sdk/python] Cast numbers intended to be integers to int #5419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently made a change to the Python codegen to emit `int` type annotations, instead of `float`, for properties that are typed as `schema.IntType`. But the number values that come back from protobuf structs are always floats (like JSON), so we need to cast the values intended to be integers to `int`.
justinvp
force-pushed
the
justin/py_sdk_int
branch
from
981ce8f
to
ceb8ca7
Compare
|
I tried out the Python example being added in pulumi/examples#799. Before these changes, I observed the same error mentioned in #5418. Then I installed a local build of the Python SDK with the changes from this PR and the |
komalali
approved these changes
Sep 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently made a change to the Python codegen to emit
inttype annotations, instead offloat, for properties that are typed asschema.IntType.But the number values that come back from protobuf structs are always floats (like JSON), so we need to cast the values intended to be integers to
int.Fixes #5418