[sdk/python] - Support enums #5615

komalali · 2020-10-23T00:03:20Z

Resolves: #5602

justinvp

Looks like there may be one thing that was included after a rebase, but otherwise LGTM!

sdk/python/lib/pulumi/runtime/rpc.py

pgavlin

One nit; LGTM otherwise.

sdk/python/lib/pulumi/runtime/rpc.py

Co-authored-by: Pat Gavlin <pat@pulumi.com>

komalali force-pushed the komalali/py-sdk-enum branch from 23bbc0c to c6dc5f1 Compare November 5, 2020 20:34

komalali force-pushed the komalali/py-sdk-enum branch from c6dc5f1 to a97d8de Compare November 23, 2020 22:18

komalali marked this pull request as ready for review November 23, 2020 22:22

komalali changed the title ~~[sdk/python] - WIP - Support enums~~ [sdk/python] - Support enums Nov 23, 2020

komalali requested review from justinvp and pgavlin November 23, 2020 23:32

komalali force-pushed the komalali/py-sdk-enum branch from 3a6a0f2 to f64e397 Compare November 24, 2020 05:01

justinvp approved these changes Nov 24, 2020

View reviewed changes

sdk/python/lib/pulumi/runtime/rpc.py Outdated Show resolved Hide resolved

pgavlin approved these changes Nov 24, 2020

View reviewed changes

sdk/python/lib/pulumi/runtime/rpc.py Outdated Show resolved Hide resolved

komalali and others added 8 commits November 24, 2020 16:46

Add serialization tests

75ef609

Add outputs test

46818ff

fix pep-9 spacing issues

8ee34fa

Deserialize enums

2efc7b8

Update changelog.

1d7addd

Fix bad merge

2e5f4f5

Update sdk/python/lib/pulumi/runtime/rpc.py

50f975f

Co-authored-by: Pat Gavlin <pat@pulumi.com>

Check if typ is a class before issubclass

cd2c0e1

komalali force-pushed the komalali/py-sdk-enum branch from 7b39426 to cd2c0e1 Compare November 24, 2020 22:46

komalali merged commit 48f4390 into master Nov 25, 2020

komalali deleted the komalali/py-sdk-enum branch November 25, 2020 01:15

Provide feedback