-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable creation of TStack using IServiceProvider #5723
Enable creation of TStack using IServiceProvider #5723
Conversation
Hi @nathanwinder-perficient thanks for this PR! One thing that we'd need to add is a test program similar to this one but with the new capability plus a corresponding Go test like here |
@mikhailshilkov I added the integration test. I am using Windows and am not able to test that locally. I see that the test suite is failing and was failing before I added my test case. I tried to confirm that my test was passing but was unable to find it in the output of the test run. |
d76ad07
to
20f0f77
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry it took me so long but I reviewed the code, made some tweaks, ran the tests in #5836
LGTM
* Enable creation of TStack using IServiceProvider to enable dependency injection. * fixed line endings * update change log * Added PR link to change log * fixed change log * Added integration test * Review adjustments Co-authored-by: Mikhail Shilkov <github@mikhail.io>
Enabled use of
IServiceProvider
for TStack instance creation. This supports the use of dependency injection when creating a stack.IServiceProvider
.TestWithServiceProviderAsync
for testing a stack that is generated using andIServiceProvider
. I would like to use an overload ofTestAsync
but the backcompat rules would not allow it.