Enable creation of TStack using IServiceProvider #5723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @nathanwinder-perficient thanks for this PR! One thing that we'd need to add is a test program similar to this one but with the new capability plus a corresponding Go test like here |
|
@mikhailshilkov I added the integration test. I am using Windows and am not able to test that locally. I see that the test suite is failing and was failing before I added my test case. I tried to confirm that my test was passing but was unable to find it in the output of the test run. |
mikhailshilkov
force-pushed
the
add-service-provider-support
branch
from
d76ad07
to
20f0f77
Compare
mikhailshilkov
approved these changes
Nov 30, 2020
There was a problem hiding this comment.
Sorry it took me so long but I reviewed the code, made some tweaks, ran the tests in #5836
LGTM
3 tasks
abhinav
pushed a commit
to pulumi/pulumi-dotnet
that referenced
this pull request
Jan 11, 2023
* Enable creation of TStack using IServiceProvider to enable dependency injection. * fixed line endings * update change log * Added PR link to change log * fixed change log * Added integration test * Review adjustments Co-authored-by: Mikhail Shilkov <github@mikhail.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled use of
IServiceProviderfor TStack instance creation. This supports the use of dependency injection when creating a stack.IServiceProvider.TestWithServiceProviderAsyncfor testing a stack that is generated using andIServiceProvider. I would like to use an overload ofTestAsyncbut the backcompat rules would not allow it.