-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable resource reference feature by default #5905
Conversation
Unless the PULUMI_DISABLE_RESOURCE_REFERENCES flag is explicitly set to a truthy value, the resource reference feature is now enabled by default.
@lblackstone, I have a WIP change that turns on resource references end-to-end for Node and Python 06ec7d6. I need to update that commit to do 2 things: 1) instead of hardcoding those to |
I opened #5908 but decided to just skip ahead to turning it on in the SDKs by default with |
That sounds good to me. |
This can be disabled by setting the `PULUMI_DISABLE_RESOURCE_REFERENCES` environment variable to a truthy value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lblackstone, your commit LGTM.
Is there a good way to get some more validation on this in examples repo, now that it'll be enabled in the SDKs as well? If we merge this in master and kick off the cron job in examples repo, will it use the dev builds of the SDKs? |
@stack72 Do you know the answer to this? |
IIRC the answer is yes. |
* Enable resource reference feature by default Unless the PULUMI_DISABLE_RESOURCE_REFERENCES flag is explicitly set to a truthy value, the resource reference feature is now enabled by default. * Set AcceptResources in the language SDKs This can be disabled by setting the `PULUMI_DISABLE_RESOURCE_REFERENCES` environment variable to a truthy value. Co-authored-by: Justin Van Patten <jvp@justinvp.com>
Unless the PULUMI_DISABLE_RESOURCE_REFERENCES flag
is explicitly set to a truthy value, the resource reference feature is now
enabled by default.
Fix #5838