Fix bug that could cause Go SDK to drop dependencies #5930
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5928
There's a marshaling loop that can run multiple times for the purposes of unpacking pointer fields. The dependency array was mistakenly declared inside the loop, causing accumulated dependencies to be clobbered if the loop runs more than once.
A similar issue was fixed for secrets via #4387, but this was missed. Reading through this method in full, it doesn't seem like there are any additional bugs of this category lurking in the loop...
Used the following program to verify the fix locally. The subnet dependency is missing from the state file before this patch, and present with the patch applied.