fix: typo to get the outputs while registering them in a mock #6040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like there are two instances of that call to log. The other immediately precedes the code that calls |
pgavlin
approved these changes
Jan 5, 2021
|
/run-acceptance-tests |
|
Please view the results of the PR Build + Acceptance Tests Run Here |
|
/run-acceptance-tests |
|
Please view the results of the PR Build + Acceptance Tests Run Here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #6039
Sidenote, to actually find the issue, I had to console log deep inside resource.js here https://github.com/pulumi/pulumi/blob/master/sdk/nodejs/runtime/resource.ts#L702
Now I'm totally not deep enough in the way it all works under the hood, but if 'err' has an error, wouldn't reject() be better than resolve()?