Respect the version option for provider resources. #6055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although raw provider resources accept an input that allows a user to specifiy a provider version to use, this input is not reflected in current SDK code generation. Furthermore, we already have a method to specify the provider version that should be used for a resource: the "version" resource option. These changes update the code that handles provider resource registrations to autmoatically populate the version input from the "version" resource option if the option is present. Fixes pulumi/pulumi-azure#803.
lblackstone
approved these changes
Jan 5, 2021
| } | ||
| p.Run(t, nil) | ||
|
|
||
| assert.Equal(t, "1.5.0", version) |
There was a problem hiding this comment.
This took me awhile to wrap my head around. IIUC, the version variable is captured by the function closures in the loaders slice so that it gets set when the loader runs? Might be worth adding a comment about that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although raw provider resources accept an input that allows a user to
specifiy a provider version to use, this input is not reflected in
current SDK code generation. Furthermore, we already have a method to
specify the provider version that should be used for a resource: the
"version" resource option. These changes update the code that handles
provider resource registrations to autmoatically populate the version
input from the "version" resource option if the option is present.
Fixes pulumi/pulumi-azure#803.