Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING] - Standardize stack select behavior #6300

Merged
merged 10 commits into from
Feb 23, 2021

Conversation

komalali
Copy link
Member

@komalali komalali commented Feb 10, 2021

This PR has 2 purposes:

  1. Standardize the --stack flag in the CLI to setCurrent=False (this is a breaking change and we will keep it in a 3.0 branch)
  2. Change the automation API implementation in each language to use the --stack flag for stack operations rather than first running selectStack, followed by the operation in question.

Note: I would like to get this PR reviewed but will hold off on merging this until we have our 3.0 branch figured out.

Fixes: #5257 and #6062

@komalali komalali added the impact/breaking Fixing this issue will require a breaking change label Feb 10, 2021
@komalali komalali force-pushed the komalali/standardize-stack-selection branch from 7f54661 to c6c7c5e Compare February 10, 2021 01:21
@komalali komalali force-pushed the komalali/standardize-stack-selection branch from b062c18 to 18c3360 Compare February 11, 2021 03:58
@komalali komalali force-pushed the komalali/standardize-stack-selection branch from 18c3360 to 6a3b380 Compare February 22, 2021 19:27
@komalali komalali marked this pull request as ready for review February 22, 2021 21:47
@stack72 stack72 changed the base branch from master to feature-3.0 February 23, 2021 19:51
stack72 and others added 9 commits February 23, 2021 19:59
As part of our continued effort to make our releases more useful,
we will be adding our CHANGELOG entries to the GitHub Release.

To make this process smooth, we are going to change things a little:

1. All new changelog entries when submitting a PR for an upcoming
release will now need to get added to CHANGELOG_PENDING.md
This is the source of information for what will be delivered in the
release.

2. When a release is being made, the entries from CHANGELOG_PENDING
will be copied to a new version and dated section in CHANGLOG to
mark the release

3. The GH tags will continue as normal and Goreleaser will copy
the changelog entries to the release section in GH
@stack72 stack72 force-pushed the komalali/standardize-stack-selection branch from 6a3b380 to 2c85990 Compare February 23, 2021 20:01
@stack72 stack72 merged commit 9536133 into feature-3.0 Feb 23, 2021
@stack72 stack72 deleted the komalali/standardize-stack-selection branch February 23, 2021 22:29
stack72 added a commit that referenced this pull request Feb 23, 2021
@stack72 stack72 restored the komalali/standardize-stack-selection branch February 23, 2021 22:31
komalali added a commit that referenced this pull request Feb 24, 2021
Co-authored-by: Paul Stack <public@paulstack.co.uk>
komalali added a commit that referenced this pull request Apr 22, 2021
Co-authored-by: Paul Stack <public@paulstack.co.uk>
komalali added a commit that referenced this pull request Apr 22, 2021
Co-authored-by: Paul Stack <public@paulstack.co.uk>

Add test for concurrent async setConfig

Add stack flag to main command

Revert "Add stack flag to main command"

This reverts commit 231d157.

Revert "Add test for concurrent async setConfig"

This reverts commit 8017ca5.

Add test for concurrent async setConfig

Revert "Revert "Add stack flag to main command""

This reverts commit 90c412f.

Fix
stack72 added a commit that referenced this pull request Apr 22, 2021
Co-authored-by: Paul Stack <public@paulstack.co.uk>
abhinav pushed a commit to pulumi/pulumi-dotnet that referenced this pull request Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/breaking Fixing this issue will require a breaking change
Projects
None yet
2 participants