[automation/python] - Use TemporaryFile and seek() #6421
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the usage of
TemporaryFile
in python automation API. Particularly in Windows,NamedTemporaryFile
cannot be reopened while it is already open, which was leading to errors. We don't need aNamedTemporaryFile
nor did we need to reopen it, we just neededseek
to get back to the beginning of the file before we read it.We don't run SDK unit tests in our Windows build which is why this wasn't caught, but I've opened an issue to track that work.
#6424 has an example of the repro and a rerun with this change included that passes.
Fixes: #6402