-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[automation/dotnet] Add ReadDiscard OperationType #6493
[automation/dotnet] Add ReadDiscard OperationType #6493
Conversation
Added an additional LocalWorkspaceTests to run the testscenario from pulumi#6485. However, this requires setting `PULUMI_TEST_ORG` environment variable prior to running the tests (for those of us without access to the `pulumi-test` organization) The OperationType is also added to the nodejs `OpType` since it was missing there as well. Fixes pulumi#6485
PR is now waiting for a maintainer to run the acceptance tests. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR |
PR is now waiting for a maintainer to run the acceptance tests. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR |
/run-acceptance-tests |
Please view the results of the PR Build + Acceptance Tests Run Here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @vipentti thanks for adding this. As you noticed, we're missing some OperationType
s from our list here. I actually just updated the nodejs list which is why you're hitting a conflict now. Could I please ask you to remove the change from stack.ts
to resolve the conflict and ideally include the additional OperationType
s to this PR.
PR is now waiting for a maintainer to run the acceptance tests. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR |
Removed the changes to |
/run-acceptance-tests |
Please view the results of the PR Build + Acceptance Tests Run Here |
PR is now waiting for a maintainer to run the acceptance tests. Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR |
Co-authored-by: Komal <komal@pulumi.com>
Added an additional LocalWorkspaceTests to run the testscenario from
#6485. However, this requires setting
PULUMI_TEST_ORG
environmentvariable prior to running the tests (for those of us without access to the
pulumi-test
organization)Fixes #6485