Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[automation/dotnet] Add ReadDiscard OperationType #6493

Merged
merged 4 commits into from
Mar 12, 2021

Conversation

vipentti
Copy link
Contributor

@vipentti vipentti commented Mar 10, 2021

Added an additional LocalWorkspaceTests to run the testscenario from
#6485. However, this requires setting PULUMI_TEST_ORG environment
variable prior to running the tests (for those of us without access to the
pulumi-test organization)

Fixes #6485

Added an additional LocalWorkspaceTests to run the testscenario from
pulumi#6485. However, this requires setting `PULUMI_TEST_ORG` environment
variable prior to running the tests (for those of us without access to the
`pulumi-test` organization)

The OperationType is also added to the nodejs `OpType` since it was missing
there as well.

Fixes pulumi#6485
@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@komalali
Copy link
Member

/run-acceptance-tests

@github-actions
Copy link

Please view the results of the PR Build + Acceptance Tests Run Here

Copy link
Member

@komalali komalali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @vipentti thanks for adding this. As you noticed, we're missing some OperationTypes from our list here. I actually just updated the nodejs list which is why you're hitting a conflict now. Could I please ask you to remove the change from stack.ts to resolve the conflict and ideally include the additional OperationTypes to this PR.

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@vipentti
Copy link
Contributor Author

Removed the changes to stack.ts and added the missing OperationTypes

@komalali
Copy link
Member

/run-acceptance-tests

@github-actions
Copy link

Please view the results of the PR Build + Acceptance Tests Run Here

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

@komalali komalali merged commit c438cad into pulumi:master Mar 12, 2021
abhinav pushed a commit to pulumi/pulumi-dotnet that referenced this pull request Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[automation/dotnet] Discarded resources cause errors after destroy
2 participants