Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in semver usage by enabling typechecking #6833

Merged
merged 2 commits into from
Apr 21, 2021
Merged

Fix bug in semver usage by enabling typechecking #6833

merged 2 commits into from
Apr 21, 2021

Conversation

t0yv0
Copy link
Member

@t0yv0 t0yv0 commented Apr 21, 2021

This bug actually prevents resources from hydrating that is:

get_resource_module('azure-native', 'authorization', '1.0.0')

Is broken..

@t0yv0 t0yv0 requested review from komalali and justinvp April 21, 2021 17:56
justinvp
justinvp approved these changes Apr 21, 2021
View reviewed changes
Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Looks like we're missing some test coverage here.

@t0yv0 t0yv0 mentioned this pull request Apr 21, 2021
Merged
@t0yv0 t0yv0 merged commit 13f63e9 into master Apr 21, 2021
@pulumi-bot pulumi-bot deleted the t0yv0/fix-check-version-bugs branch April 21, 2021 19:49
@t0yv0
Copy link
Member Author

t0yv0 commented Apr 21, 2021

Taking a note, I'll follow up on where to add coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinvp justinvp justinvp approved these changes

@komalali komalali komalali approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@t0yv0 @justinvp @komalali