Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dotnet/sdk] Add create unknown to output utilities #7173

Merged
merged 4 commits into from
Jun 10, 2021
Merged

[dotnet/sdk] Add create unknown to output utilities #7173

merged 4 commits into from
Jun 10, 2021

Conversation

gitfool
Copy link
Contributor

@gitfool gitfool commented May 30, 2021 •
edited

Description

Fixes #7172.

Checklist

  • I have added tests that prove my fix is effective or that my feature works

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Further commands available:

  • /run-codegen - used to test the Pull Request against downstream codegen
  • /run-docs-gen - used to test the Pull Request against documentation generation

1 similar comment
@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Further commands available:

  • /run-codegen - used to test the Pull Request against downstream codegen
  • /run-docs-gen - used to test the Pull Request against documentation generation

@gitfool
Copy link
Contributor Author

gitfool commented May 30, 2021

@mikhailshilkov PTAL

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Further commands available:

  • /run-codegen - used to test the Pull Request against downstream codegen
  • /run-docs-gen - used to test the Pull Request against documentation generation

@gitfool gitfool changed the title [dotnet/sdk] Add create unknown to output [dotnet/sdk] Add create unknown to output utilities May 31, 2021
@gitfool
Copy link
Contributor Author

gitfool commented May 31, 2021

@mikhailshilkov I've addressed your initial review.

@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Further commands available:

  • /run-codegen - used to test the Pull Request against downstream codegen
  • /run-docs-gen - used to test the Pull Request against documentation generation

@mikhailshilkov mikhailshilkov requested a review from t0yv0 June 8, 2021 08:36
@mikhailshilkov
Copy link
Member

/run-acceptance-tests

@github-actions
Copy link

github-actions bot commented Jun 8, 2021

Please view the results of the PR Build + Acceptance Tests Run Here

t0yv0
t0yv0 approved these changes Jun 8, 2021
View reviewed changes
Copy link
Member

@t0yv0 t0yv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with the usual uneasiness about exposing more internals, but I do believe it's useful in testing..

@github-actions
Copy link

github-actions bot commented Jun 9, 2021

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Further commands available:

  • /run-codegen - used to test the Pull Request against downstream codegen
  • /run-docs-gen - used to test the Pull Request against documentation generation

@gitfool
Copy link
Contributor Author

gitfool commented Jun 9, 2021

@t0yv0 I've addressed your review too.

@t0yv0 t0yv0 added the size/S Estimated effort to complete (1-2 days). label Jun 9, 2021
@t0yv0 t0yv0 added this to the 0.58 milestone Jun 9, 2021
@t0yv0
Copy link
Member

t0yv0 commented Jun 9, 2021

/run-acceptance-tests

@github-actions
Copy link

github-actions bot commented Jun 9, 2021

Please view the results of the PR Build + Acceptance Tests Run Here

@t0yv0
Copy link
Member

t0yv0 commented Jun 10, 2021

I believe the test failures are not related. Merging up.

@t0yv0 t0yv0 merged commit c4e55a7 into pulumi:master Jun 10, 2021
@github-actions
Copy link

PR is now waiting for a maintainer to run the acceptance tests.

Note for the maintainer: To run the acceptance tests, please comment /run-acceptance-tests on the PR

Further commands available:

  • /run-codegen - used to test the Pull Request against downstream codegen
  • /run-docs-gen - used to test the Pull Request against documentation generation

@gitfool gitfool deleted the gh7172 branch June 10, 2021 18:15
abhinav pushed a commit to pulumi/pulumi-dotnet that referenced this pull request Jan 11, 2023
@gitfool @t0yv0
[dotnet/sdk] Add create unknown to output utilities (pulumi/pulumi#7173)
5533913 
* Add create unknown to output utilities

* Update changelog

* Tweaks based on review

Co-authored-by: Anton Tayanovskyy <anton@pulumi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikhailshilkov mikhailshilkov mikhailshilkov left review comments

@t0yv0 t0yv0 t0yv0 approved these changes

Assignees
No one assigned
Labels
size/S Estimated effort to complete (1-2 days).
Projects
None yet
Milestone
0.58
Development

Successfully merging this pull request may close these issues.

[dotnet/sdk] Add OutputUtilities.CreateUnknown
3 participants
@gitfool @mikhailshilkov @t0yv0