Read passphrase from the terminal when rotating. #7347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rotating a passphrase requires that the old passphrase is available via one of the `PULUMI_CONFIG_PASSPHRASE` or `PULUMI_CONFIG_PASSPHRASE_FILE` environment variables. This confuses `readPassphrase` when reading a new passphrase, since that function checks the aforementioned environment variables prior to reading from the console. The overall effect is that it is impossible to rotate the passphrase for a stack using the passphrase provider. These changes fix this by always reading from the console when rotating a passphrase.
lukehoban
approved these changes
Jun 22, 2021
Working on an integration test. |
This was surprisingly annoying. It did, however, find a bug in the code we use to read from stdin, which could read beyond the end of the input when stdin is not a terminal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rotating a passphrase requires that the old passphrase is available via
one of the
PULUMI_CONFIG_PASSPHRASEorPULUMI_CONFIG_PASSPHRASE_FILEenvironment variables. This confuses
readPassphrasewhen reading a newpassphrase, since that function checks the aforementioned environment
variables prior to reading from the console. The overall effect is that
it is impossible to rotate the passphrase for a stack using the
passphrase provider. These changes fix this by always reading from the
console when rotating a passphrase.