Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[codegen/nodejs] - Dynamic provider config getters #7530

Merged
merged 5 commits into from
Jul 16, 2021
Merged

[codegen/nodejs] - Dynamic provider config getters #7530

merged 5 commits into from
Jul 16, 2021

Conversation

komalali
Copy link
Member

@komalali komalali commented Jul 14, 2021 •
edited

Description

Nodejs part of #5582

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@komalali komalali force-pushed the komalali/node-dynamic-config branch from ccd4146 to 9ee034e Compare July 14, 2021 23:06
@github-actions
Copy link

Diff for pulumi-random with merge commit ba1aec3

justinvp
justinvp reviewed Jul 15, 2021
View reviewed changes
pkg/codegen/nodejs/gen.go Outdated Show resolved Hide resolved
justinvp
justinvp reviewed Jul 15, 2021
View reviewed changes
pkg/codegen/nodejs/gen.go Outdated Show resolved Hide resolved
@komalali komalali marked this pull request as ready for review July 15, 2021 16:36
@komalali komalali changed the title [WIP] - [codegen/nodejs] - Dynamic provider config getters [codegen/nodejs] - Dynamic provider config getters Jul 15, 2021
@github-actions
Copy link

Diff for pulumi-azuread with merge commit d10b7e6

@github-actions
Copy link

Diff for pulumi-random with merge commit d10b7e6

@github-actions
Copy link

Diff for pulumi-random with merge commit 18eb428

@github-actions
Copy link

Diff for pulumi-azuread with merge commit 18eb428

@github-actions
Copy link

Diff for pulumi-gcp with merge commit d10b7e6

@github-actions
Copy link

Diff for pulumi-azure with merge commit d10b7e6

@github-actions
Copy link

Diff for pulumi-gcp with merge commit 18eb428

@github-actions
Copy link

Diff for pulumi-azure with merge commit 18eb428

@github-actions
Copy link

Diff for pulumi-aws with merge commit d10b7e6

@github-actions
Copy link

Diff for pulumi-aws with merge commit 18eb428

@github-actions
Copy link

Diff for pulumi-random with merge commit dcfc39f

@github-actions
Copy link

Diff for pulumi-azuread with merge commit dcfc39f

@github-actions
Copy link

Diff for pulumi-gcp with merge commit dcfc39f

@github-actions
Copy link

Diff for pulumi-azure with merge commit dcfc39f

@github-actions
Copy link

Diff for pulumi-aws with merge commit dcfc39f

@komalali komalali force-pushed the komalali/node-dynamic-config branch from bdc563e to 909fc53 Compare July 15, 2021 20:26
@github-actions
Copy link

Diff for pulumi-azuread with merge commit 544d47c

@github-actions
Copy link

Diff for pulumi-random with merge commit 544d47c

@github-actions
Copy link

Diff for pulumi-gcp with merge commit 544d47c

@komalali komalali requested a review from justinvp July 15, 2021 20:41
@github-actions
Copy link

Diff for pulumi-random with merge commit 0507380

@github-actions
Copy link

Diff for pulumi-azuread with merge commit 0507380

@github-actions
Copy link

Diff for pulumi-azure with merge commit 544d47c

@github-actions
Copy link

Diff for pulumi-gcp with merge commit 0507380

@github-actions
Copy link

Diff for pulumi-azure with merge commit 0507380

@github-actions
Copy link

Diff for pulumi-aws with merge commit 544d47c

@github-actions
Copy link

Diff for pulumi-aws with merge commit 0507380

@komalali komalali requested review from pgavlin and t0yv0 July 16, 2021 00:28
@komalali komalali mentioned this pull request Jul 16, 2021
Closed
3 tasks
t0yv0
t0yv0 reviewed Jul 16, 2021
View reviewed changes
pkg/codegen/nodejs/gen.go
// Specifically, this doesn't work right if the first value is set to false but the default value
// is true.
configFetch += " || " + v
configFetch += " ?? " + v
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's null coalescing operator? Awesome.

t0yv0
t0yv0 approved these changes Jul 16, 2021
View reviewed changes
Copy link
Member

@t0yv0 t0yv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wunderbar, I am learning some TypeScript tricks here, thanks.

justinvp
justinvp approved these changes Jul 16, 2021
View reviewed changes
Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

With the TypeScript upgrade, it's worth noting that it's no longer possible to set these values (given the new TypeScript => JavaScript transpiled code), so it'll no longer be possible to do things like this. But this change addresses the problem that that's working around, so there's no longer a need to do that.

@t0yv0
Copy link
Member

t0yv0 commented Jul 16, 2021

It's great not to be able to do things like that.

@komalali komalali merged commit 490e9cf into master Jul 16, 2021
@pulumi-bot pulumi-bot deleted the komalali/node-dynamic-config branch July 16, 2021 16:52
@komalali komalali mentioned this pull request Jul 20, 2021
Closed
3 tasks
@justinvp justinvp mentioned this pull request Jun 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t0yv0 t0yv0 t0yv0 approved these changes

@justinvp justinvp justinvp approved these changes

@pgavlin pgavlin Awaiting requested review from pgavlin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@komalali @t0yv0 @justinvp