[sdk] Wait on remote component dependencies #7541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a resource `dependsOn` a remote component, we were not correctly waiting on it, because we were skipping over waiting on comoponents, and only waiting on their custom resource children. For remote components, we do not know the children, but waiting on the remote component will always wait on all children. Fixes #7540
lukehoban
force-pushed
the
lukehoban/7540
branch
from
1ef1130
to
da66e59
Compare
metral
reviewed
Jul 15, 2021
Co-authored-by: Mike Metral <1112768+metral@users.noreply.github.com>
lukehoban
changed the title
pgavlin
approved these changes
Jul 16, 2021
lukehoban
changed the title
lukehoban
force-pushed
the
lukehoban/7540
branch
from
29025f8
to
23f2c4d
Compare
lukehoban
force-pushed
the
lukehoban/7540
branch
from
23f2c4d
to
22ee883
Compare
There were baseline differences here (which are now fixed by this PR) - so this commit brings the tests into alignment across languages since we now expect to have the same behaviour in each.
3 tasks
abhinav
pushed a commit
to pulumi/pulumi-dotnet
that referenced
this pull request
Jan 11, 2023
When a resource `dependsOn` a remote component, we were not correctly waiting on it, because we were skipping over waiting on comoponents, and only waiting on their custom resource children. For remote components, we do not know the children, but waiting on the remote component will always wait on all children. Co-authored-by: Mike Metral <1112768+metral@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a resource
dependsOna remote component, we were not correctly waiting on it, because we were skipping over waiting on components, and only waiting on their custom resource children. For remote components, we do not know the children, but waiting on the remote component will always wait on all children.This fixes the Node.js and .NET SDKs which both contain this approach to collecting transitive dependencies. The Go and Python SDKs use a different approach which did not have this bug. #7542 is tracking aligning the implementations as a follow-up.
Fixes #7540.