[sdk/go] Fix a typo in marshaling. #7768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few identically-typed variables got confused with the changes in #7737. The confusion caused empty property values to be included in resources that had any dependencies on other resources, which confused the unmarshaling code for Go multi-language components. These changes fix the typo and restore the original behavior, which is to omit empty property values.
t0yv0
reviewed
Aug 16, 2021
| @@ -148,7 +148,7 @@ func marshalInputs(props Input) (resource.PropertyMap, map[string][]URN, []URN, | |||
| pdeps[pname] = allDeps.values() | |||
| } | |||
|
|
|||
| if !v.IsNull() || len(deps) > 0 { | |||
| if !v.IsNull() || len(allDeps) > 0 { | |||
There was a problem hiding this comment.
Oof I could've caught that at review.
t0yv0
approved these changes
Aug 16, 2021
|
Assuming the test is "broken -> fixed" with the change, LGTM. |
EvanBoyle
approved these changes
Aug 16, 2021
|
Test failure is unrelated (in .NET tests, which are not affected by this change). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few identically-typed variables got confused with the changes in #7737.
The confusion caused empty property values to be included in resources
that had any dependencies on other resources, which confused the
unmarshaling code for Go multi-language components. These changes fix
the typo and restore the original behavior, which is to omit empty
property values.