Bold in-progress diffs diffrently

[iwahbe]

Description

This feature makes it easier to see which diffs are in progress vs completed. It does this by bolding the colors of steps that are in progress.

Fixes #7337

Checklist

• I have added tests that prove my fix is effective or that my feature works

• I have updated the CHANGELOG-PENDING file with my change

• Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

[susanev]

@iwahbe thanks for chatting with me today!!

here's my recommendation: lets leave all colors alone except for the +, -, and status. and because of the accessibility issues here lets use the colors you have for created and deleted (and corresponding +,-), and have creating and deleting (and corresponding +,-) be the same white as the other text in the table. folks will be able to more easily scan the green/white and red/white vs green/light-green and red/light-red.

what do you think?

[iwahbe]

I think that folks will be more able to scan the green/neutral and red/neutral then the color mix. The problem I have is that except at stack creation and stack destruction, most commands will invoke a combination of create, delete, update and replace CRUD operations, each represented with their own color. My example didn't have that because I'm not playing with a complicated stack. If we implement your suggestion, we will get create visibility into what is in progress vs done, but will loose visibility into what type of operations are in progress.

Right now I have it set up to split the difference. The user can choose if they want to see full color (difference between progress and pending within a color), or partial color (only completed operations are colored).

@susanev How does that look from your end?

[github-actions]

Diff for pulumi-azuread with merge commit 8685e25

[github-actions]

Diff for pulumi-random with merge commit 8685e25

[github-actions]

Diff for pulumi-kubernetes with merge commit 8685e25

[github-actions]

Diff for pulumi-aws with merge commit 8685e25

[github-actions]

Diff for pulumi-gcp with merge commit 8685e25

[github-actions]

Diff for pulumi-azure with merge commit 8685e25

[susanev]

lets def decide on one change together. i dont htink this situation calls for allowing folks to pick two different solutions. imma take a closer look at all the colors we are using so we can figure out a way to go with your solution but also not introduce contrast issues. ill get back to ya as soon as i can.

[susanev]

im not gonna approve cause i havent reviewed the code, but based on the video you sent me im good with this change. thx for doing this work!!

[komalali]

This looks great @iwahbe ! Just a couple of minor clean-up questions and then should be good to go.

[iwahbe]

@komalali Thanks for pointing out the convention.

Is this a leftover?

This was a good catch!

Curious why you removed the colors. from the comment here?

Because it made less sense in an earlier commit. I should have restored it. (and now I did)

[justinvp]

I haven't had a chance to try this out. Mind sharing the video, or a screenshot, or https://asciinema.org?

[iwahbe]

I haven't had a chance to try this out. Mind sharing the video, or a screenshot, or https://asciinema.org?

I'd be happy to.
https://user-images.githubusercontent.com/22222529/135171528-b71759bf-cfc5-4a6e-84fc-b00425aad17a.mov

[komalali]

LGTM!