Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[codegen/nodejs] - Fix provider enum with env var #8051

Merged
merged 3 commits into from
Sep 24, 2021
Merged

[codegen/nodejs] - Fix provider enum with env var #8051

merged 3 commits into from
Sep 24, 2021

Conversation

komalali
Copy link
Member

Description

Fixes #8042

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@github-actions
Copy link

Diff for pulumi-random with merge commit 2054c22

@github-actions
Copy link

Diff for pulumi-azuread with merge commit 2054c22

@github-actions
Copy link

Diff for pulumi-azuread with merge commit ea803ca

@github-actions
Copy link

Diff for pulumi-random with merge commit ea803ca

@github-actions
Copy link

Diff for pulumi-kubernetes with merge commit 2054c22

@github-actions
Copy link

Diff for pulumi-gcp with merge commit 2054c22

@github-actions
Copy link

Diff for pulumi-kubernetes with merge commit ea803ca

@github-actions
Copy link

Diff for pulumi-gcp with merge commit ea803ca

@github-actions
Copy link

Diff for pulumi-aws with merge commit 2054c22

@github-actions
Copy link

Diff for pulumi-aws with merge commit ea803ca

@github-actions
Copy link

Diff for pulumi-azure with merge commit ea803ca

@github-actions
Copy link

Diff for pulumi-azure with merge commit 2054c22

@github-actions
Copy link

Diff for pulumi-azure-native with merge commit ea803ca

@github-actions
Copy link

Diff for pulumi-azure-native with merge commit 2054c22

@github-actions
Copy link

Diff for pulumi-random with merge commit 8a0a434

@github-actions
Copy link

Diff for pulumi-azuread with merge commit 8a0a434

@github-actions
Copy link

Diff for pulumi-kubernetes with merge commit 8a0a434

@github-actions
Copy link

Diff for pulumi-gcp with merge commit 8a0a434

@github-actions
Copy link

Diff for pulumi-aws with merge commit 8a0a434

@github-actions
Copy link

Diff for pulumi-azure with merge commit 8a0a434

@komalali komalali requested a review from a team September 24, 2021 17:11
@github-actions
Copy link

Diff for pulumi-azure-native with merge commit 8a0a434

lblackstone
lblackstone approved these changes Sep 24, 2021
View reviewed changes
Copy link
Member

@lblackstone lblackstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that was fast! Thanks!

pgavlin
pgavlin reviewed Sep 24, 2021
View reviewed changes
Copy link
Member

@pgavlin pgavlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM--just one question re: clarifying a case

pkg/codegen/nodejs/gen.go Show resolved Hide resolved
@github-actions
Copy link

Diff for pulumi-random with merge commit 0cb91c2

@github-actions
Copy link

Diff for pulumi-azuread with merge commit 0cb91c2

@github-actions
Copy link

Diff for pulumi-kubernetes with merge commit 0cb91c2

@github-actions
Copy link

Diff for pulumi-gcp with merge commit 0cb91c2

@github-actions
Copy link

Diff for pulumi-aws with merge commit 0cb91c2

@github-actions
Copy link

Diff for pulumi-random with merge commit e3dbaac

@github-actions
Copy link

Diff for pulumi-azure with merge commit 0cb91c2

@github-actions
Copy link

Diff for pulumi-azuread with merge commit e3dbaac

@github-actions
Copy link

Diff for pulumi-kubernetes with merge commit e3dbaac

@github-actions
Copy link

Diff for pulumi-gcp with merge commit e3dbaac

@github-actions
Copy link

Diff for pulumi-azure with merge commit e3dbaac

@github-actions
Copy link

Diff for pulumi-aws with merge commit e3dbaac

@github-actions
Copy link

Diff for pulumi-azure-native with merge commit 0cb91c2

@github-actions
Copy link

Diff for pulumi-random with merge commit 05b80b8

@github-actions
Copy link

Diff for pulumi-azuread with merge commit 05b80b8

@github-actions
Copy link

Diff for pulumi-kubernetes with merge commit 05b80b8

@github-actions
Copy link

Diff for pulumi-gcp with merge commit 05b80b8

@github-actions
Copy link

Diff for pulumi-aws with merge commit 05b80b8

@github-actions
Copy link

Diff for pulumi-azure-native with merge commit e3dbaac

@github-actions
Copy link

Diff for pulumi-azure with merge commit 05b80b8

@github-actions
Copy link

Diff for pulumi-azure-native with merge commit 05b80b8

@komalali
Copy link
Member Author

Unrelated test failure, merging

@komalali komalali merged commit 74dfa83 into master Sep 24, 2021
@pulumi-bot pulumi-bot deleted the komalali/nodejs-enum branch September 24, 2021 22:03
@t0yv0 t0yv0 mentioned this pull request Sep 27, 2021
Open
@t0yv0
Copy link
Member

t0yv0 commented Sep 27, 2021

Collected into flaky list: #8061

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t0yv0 t0yv0 t0yv0 approved these changes

@pgavlin pgavlin pgavlin approved these changes

@lblackstone lblackstone lblackstone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[nodejs] Provider enum with env vars generates invalid code
4 participants
@komalali @t0yv0 @pgavlin @lblackstone