Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tsconfig option to specify tsconfig path #8452

Merged
merged 5 commits into from
Nov 22, 2021

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Nov 18, 2021

Description

Adds a runtime option to specify the path to tsconfig.json.

name: pulumi-project
runtime:
  name: nodejs
  options:
    tsconfig: mytsconfig.json

Fixes #8415

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@iwahbe iwahbe marked this pull request as draft November 18, 2021 21:52
@iwahbe iwahbe marked this pull request as ready for review November 19, 2021 18:52
@iwahbe iwahbe requested a review from a team November 19, 2021 18:52
@iwahbe iwahbe self-assigned this Nov 19, 2021
@iwahbe iwahbe added area/cli UX of using the CLI (args, output, logs) language/javascript labels Nov 19, 2021
Copy link
Member

@t0yv0 t0yv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good I'm just confused how the new option flows from project yaml into main() arg of pulumi-language-nodejs language provider. Does the code just generically splice options into cmd-line args?

@iwahbe
Copy link
Member Author

iwahbe commented Nov 22, 2021

I'm just confused how the new option flows from project yaml into main() arg of pulumi-language-nodejs language provider. Does the code just generically splice options into cmd-line args?

Yup. If you want to demonstrate this, add a garbage option to options:

name: digitalocean-cs-loadbalanced-droplets
runtime: 
  name: dotnet
  options:
    foo: bar

Running pulumi preview yields

Diagnostics:
  pulumi:pulumi:Stack (digitalocean-cs-loadbalanced-droplets-dev):
    flag provided but not defined: -foo

@iwahbe iwahbe merged commit d9dd88c into master Nov 22, 2021
@pulumi-bot pulumi-bot deleted the iwahbe/8415/tsconfig-path-in-runtime-options branch November 22, 2021 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli UX of using the CLI (args, output, logs) language/javascript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tsconfig "module" conflict: project needs "esnext", pulumi needs "commonjs"
2 participants