[backend/filestate] Don't unwrap go-cloud errors #8455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praneetloke
commented
Nov 19, 2021
| @@ -323,7 +323,7 @@ func (b *localBackend) GetStack(ctx context.Context, stackRef backend.StackRefer | |||
| snapshot, path, err := b.getStack(stackName) | |||
|
|
|||
| switch { | |||
| case gcerrors.Code(drillError(err)) == gcerrors.NotFound: | |||
| case gcerrors.Code(err) == gcerrors.NotFound: | |||
There was a problem hiding this comment.
The problem seems to be that we are passing the unwrapped error to go-cloud's Code func which tries to find a matching error that it can assign as gcerr.Error. So when it is passed an already-unwrapped error, it fails return the error code that we expect to compare against.
There was a problem hiding this comment.
Ah, gcerrors itself is wrapping errors, so when we unwrap the chain, it prevents gcerrors.Code from finding its wrapped error. This is my bad, I had suggested unwrapping the full chain to @iwahbe since we are also wrapping, not realizing that gcerrors itself is wrapping and relying on it. Sorry about that @iwahbe.
|
I didn't update the changelog, but I think this PR does warrant an entry. |
iwahbe
approved these changes
Nov 19, 2021
justinvp
approved these changes
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pulumi CLI fails with the following error when running
pulumi stack select dev2 -cto select a stack but first creating it, if it does not exist already.Fixes #8461 (Related to #8406)
Checklist