Fix 7422 - NullPointerException race on Urn property in C# SDK #8495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can confirm that
This seems to fix that at least:
|
3 tasks
t0yv0
force-pushed
the
t0yv0/fix-nil-urn
branch
from
f223ba0
to
043d328
Compare
t0yv0
changed the title
Codecov Report
@@ Coverage Diff @@
## master #8495 +/- ##
==========================================
+ Coverage 58.70% 58.74% +0.04%
==========================================
Files 634 634
Lines 96948 96950 +2
Branches 1378 1378
==========================================
+ Hits 56910 56953 +43
+ Misses 36776 36730 -46
- Partials 3262 3267 +5
Continue to review full report at Codecov.
|
justinvp
approved these changes
Dec 10, 2021
t0yv0
force-pushed
the
t0yv0/fix-nil-urn
branch
from
2b5520b
to
2985174
Compare
abhinav
pushed a commit
to pulumi/pulumi-dotnet
that referenced
this pull request
Jan 11, 2023
…i/pulumi#8495) * Prevent observable null Urn outputs * Tests * Formatting * CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Under certain conditions, C# SDK can race to observe nulls in Urn property of a resource. This is reproduced via a non-deterministic mock test, and fixed in this PR.
Fixes #7422
On top of #8577 (requires merging that first).
Checklist