Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdk/go] Normalize providers merge #8882

Merged
merged 13 commits into from
Feb 8, 2022
Merged

Conversation

iwahbe
Copy link
Member

@iwahbe iwahbe commented Jan 31, 2022

Description

This is the final SDK change.
Fixes #8796

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • Yes, there are changes in this PR that warrants bumping the Pulumi Service API version

@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #8882 (fbc66dd) into master (a1e18da) will increase coverage by 0.00%.
The diff coverage is 48.48%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8882   +/-   ##
=======================================
  Coverage   59.39%   59.39%           
=======================================
  Files         642      642           
  Lines       99667    99685   +18     
  Branches     1392     1392           
=======================================
+ Hits        59195    59210   +15     
+ Misses      37095    37092    -3     
- Partials     3377     3383    +6     
Impacted Files Coverage Δ
sdk/go/pulumi/context.go 59.90% <48.48%> (-0.27%) ⬇️
sdk/python/lib/pulumi/automation/_server.py 84.61% <0.00%> (-4.62%) ⬇️
sdk/go/common/util/cmdutil/spinner.go 21.27% <0.00%> (-4.26%) ⬇️
...k/dotnet/Pulumi/Deployment/TaskMonitoringHelper.cs 96.29% <0.00%> (-3.71%) ⬇️
sdk/go/common/resource/plugin/plugin.go 66.51% <0.00%> (-1.36%) ⬇️
sdk/go/common/resource/plugin/host.go 50.80% <0.00%> (-1.21%) ⬇️
sdk/python/lib/pulumi/runtime/stack.py 72.26% <0.00%> (-0.85%) ⬇️
sdk/nodejs/automation/localWorkspace.ts 74.03% <0.00%> (-0.39%) ⬇️
sdk/go/common/resource/properties.go 83.70% <0.00%> (+1.10%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1e18da...fbc66dd. Read the comment docs.

@iwahbe iwahbe requested review from Frassle and t0yv0 February 3, 2022 14:21
@iwahbe iwahbe self-assigned this Feb 3, 2022
Copy link
Member

@t0yv0 t0yv0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looking good, wondering how we could test it.

@@ -231,9 +231,6 @@ jobs:
- name: Lint .NET
run: |
cd sdk/dotnet && make lint
- name: Lint Go
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No big deal but normally try to open dedicated PRs for this - I'll try to be better reviewing those promptly so there's no incentive to "batch PRs" to increase throughput. This comes in handy later on when digging in the project history git blame points to topically targeted changes.

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Diff for pulumi-azuread with merge commit 8731650

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Diff for pulumi-random with merge commit 8731650

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Diff for pulumi-gcp with merge commit 8731650

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Diff for pulumi-kubernetes with merge commit 8731650

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Diff for pulumi-azure with merge commit 8731650

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Diff for pulumi-random with merge commit e9874f8

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Diff for pulumi-azuread with merge commit e9874f8

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Diff for pulumi-kubernetes with merge commit e9874f8

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Diff for pulumi-gcp with merge commit e9874f8

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Diff for pulumi-aws with merge commit 8731650

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Diff for pulumi-azure with merge commit e9874f8

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Diff for pulumi-aws with merge commit e9874f8

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Diff for pulumi-random with merge commit f638033

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Diff for pulumi-azuread with merge commit f638033

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Diff for pulumi-kubernetes with merge commit f638033

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Diff for pulumi-gcp with merge commit f638033

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Diff for pulumi-azure with merge commit f638033

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Diff for pulumi-aws with merge commit f638033

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

Diff for pulumi-azure-native with merge commit f638033

@github-actions
Copy link

github-actions bot commented Feb 8, 2022

Diff for pulumi-azuread with merge commit 356b137

@github-actions
Copy link

github-actions bot commented Feb 8, 2022

Diff for pulumi-random with merge commit 356b137

@github-actions
Copy link

github-actions bot commented Feb 8, 2022

Diff for pulumi-kubernetes with merge commit 356b137

@github-actions
Copy link

github-actions bot commented Feb 8, 2022

Diff for pulumi-gcp with merge commit 356b137

@github-actions
Copy link

github-actions bot commented Feb 8, 2022

Diff for pulumi-azure with merge commit 356b137

@github-actions
Copy link

github-actions bot commented Feb 8, 2022

Diff for pulumi-aws with merge commit 356b137

@github-actions
Copy link

github-actions bot commented Feb 8, 2022

Diff for pulumi-azure-native with merge commit 356b137

@iwahbe iwahbe merged commit 8666d9c into master Feb 8, 2022
@pulumi-bot pulumi-bot deleted the iwahbe/go-normalize-providers-merge branch February 8, 2022 14:35
@iwahbe iwahbe changed the title Normalize providers merge [sdk/go] Normalize providers merge Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking Issue: Standardize provider and providers behaviour
2 participants