-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sdk/go] Normalize providers merge #8882
Conversation
Codecov Report
@@ Coverage Diff @@
## master #8882 +/- ##
=======================================
Coverage 59.39% 59.39%
=======================================
Files 642 642
Lines 99667 99685 +18
Branches 1392 1392
=======================================
+ Hits 59195 59210 +15
+ Misses 37095 37092 -3
- Partials 3377 3383 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looking good, wondering how we could test it.
.github/workflows/master.yml
Outdated
@@ -231,9 +231,6 @@ jobs: | |||
- name: Lint .NET | |||
run: | | |||
cd sdk/dotnet && make lint | |||
- name: Lint Go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No big deal but normally try to open dedicated PRs for this - I'll try to be better reviewing those promptly so there's no incentive to "batch PRs" to increase throughput. This comes in handy later on when digging in the project history git blame
points to topically targeted changes.
Diff for pulumi-azuread with merge commit 8731650 |
Diff for pulumi-random with merge commit 8731650 |
Diff for pulumi-gcp with merge commit 8731650 |
Diff for pulumi-kubernetes with merge commit 8731650 |
Diff for pulumi-azure with merge commit 8731650 |
Diff for pulumi-random with merge commit e9874f8 |
Diff for pulumi-azuread with merge commit e9874f8 |
Diff for pulumi-kubernetes with merge commit e9874f8 |
Diff for pulumi-gcp with merge commit e9874f8 |
Diff for pulumi-aws with merge commit 8731650 |
Diff for pulumi-azure with merge commit e9874f8 |
Diff for pulumi-aws with merge commit e9874f8 |
Diff for pulumi-random with merge commit f638033 |
Diff for pulumi-azuread with merge commit f638033 |
Diff for pulumi-kubernetes with merge commit f638033 |
Diff for pulumi-gcp with merge commit f638033 |
Diff for pulumi-azure with merge commit f638033 |
Diff for pulumi-aws with merge commit f638033 |
Diff for pulumi-azure-native with merge commit f638033 |
Diff for pulumi-azuread with merge commit 356b137 |
Diff for pulumi-random with merge commit 356b137 |
Diff for pulumi-kubernetes with merge commit 356b137 |
Diff for pulumi-gcp with merge commit 356b137 |
Diff for pulumi-azure with merge commit 356b137 |
Diff for pulumi-aws with merge commit 356b137 |
Diff for pulumi-azure-native with merge commit 356b137 |
Description
This is the final SDK change.
Fixes #8796
Checklist