Serialize resource registration after inputs resolve #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 26, 2018
lukehoban
added
impact/changelog
impact/breaking
swgillespie
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 71beb2a.
Per https://github.com/pulumi/design/blob/master/meetings/2018/2018-02-13.md#decision-1, this PR re-enables @pgavlin 's deadlock fix in the hopes of working through all of the dependency issues that crop up in
pulumi-cloud. The strategy is that we will fix implicit dependency issues by merging any necessary dependency information ontoOutputs that we are currently missing.We might need #960 to fully understand all of the issues that we are facing here, though this PR can at least reveal the immediate issues.
Fixes #959.