Permalink
Commits on Sep 7, 2016
  1. minor #19875 Use DI exceptions in components compiler passes (chalasr)

    This PR was merged into the 3.2-dev branch.
    
    Discussion
    ----------
    
    Use DI exceptions in components compiler passes
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | License       | MIT
    
    Commits
    -------
    
    f2e30bc Use DI exceptions in components compiler passes
    fabpot committed Sep 7, 2016
Commits on Sep 6, 2016
  1. Merge branch '3.1'

    * 3.1:
      [FrameworkBundle] Check for class existence before is_subclass_of
      Update GroupSequence.php
      Code enhancement and cleanup
      [Form] Fix transformer tests after the ICU update
      [DI] Add anti-regression test
      Revert "minor #19689 [DI] Cleanup array_key_exists (ro0NL)"
      bumped Symfony version to 3.1.5
      updated VERSION for 3.1.4
      updated CHANGELOG for 3.1.4
      bumped Symfony version to 2.8.11
      updated VERSION for 2.8.10
      updated CHANGELOG for 2.8.10
      [BrowserKit] Fix cookie expiration on 32 bit systems
      bumped Symfony version to 2.7.18
      updated VERSION for 2.7.17
      update CONTRIBUTORS for 2.7.17
      updated CHANGELOG for 2.7.17
      Update misleading comment about RFC4627
    nicolas-grekas committed Sep 6, 2016
  2. Merge branch '2.8' into 3.1

    * 2.8:
      [FrameworkBundle] Check for class existence before is_subclass_of
      Update GroupSequence.php
      Code enhancement and cleanup
      [Form] Fix transformer tests after the ICU update
      [DI] Add anti-regression test
      Revert "minor #19689 [DI] Cleanup array_key_exists (ro0NL)"
      bumped Symfony version to 2.8.11
      updated VERSION for 2.8.10
      updated CHANGELOG for 2.8.10
      [BrowserKit] Fix cookie expiration on 32 bit systems
      bumped Symfony version to 2.7.18
      updated VERSION for 2.7.17
      update CONTRIBUTORS for 2.7.17
      updated CHANGELOG for 2.7.17
      Update misleading comment about RFC4627
    nicolas-grekas committed Sep 6, 2016
  3. Merge branch '2.7' into 2.8

    * 2.7:
      [FrameworkBundle] Check for class existence before is_subclass_of
      Update GroupSequence.php
      Code enhancement and cleanup
      [DI] Add anti-regression test
      Revert "minor #19689 [DI] Cleanup array_key_exists (ro0NL)"
      [BrowserKit] Fix cookie expiration on 32 bit systems
      bumped Symfony version to 2.7.18
      updated VERSION for 2.7.17
      update CONTRIBUTORS for 2.7.17
      updated CHANGELOG for 2.7.17
      Update misleading comment about RFC4627
    nicolas-grekas committed Sep 6, 2016
  4. bug #19848 Revert "minor #19689 [DI] Cleanup array_key_exists (ro0NL)…

    …" (nicolas-grekas)
    
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    Revert "minor #19689 [DI] Cleanup array_key_exists (ro0NL)"
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | yes
    | Tests pass?   | yes
    | Fixed tickets | #19689 #19840 #19825 #19857
    | License       | MIT
    | Doc PR        | -
    
    This reverts commit c89f80a, reversing
    changes made to 386e5e7.
    
    See discussion in #19847
    
    I'll try adding test cases soon that ensure that:
    
    - [x] *when not leaving scope* synthetic services always throw and ignore the `ContainerInterface::NULL_ON_INVALID_REFERENCE` flag (on 3.x also)
    - [x] *when leaving scope* synthetic services always return null and ignore the `ContainerInterface::EXCEPTION_ON_INVALID_REFERENCE`  (until 2.8 since scopes are gone in 3.x)
    
    Commits
    -------
    
    8cb28bf [DI] Add anti-regression test
    ac742df Revert "minor #19689 [DI] Cleanup array_key_exists (ro0NL)"
    nicolas-grekas committed Sep 6, 2016
  5. minor #19809 Update misleading comment about RFC4627 (teohhanhui)

    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    Update misleading comment about RFC4627
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | N/A
    | License       | MIT
    | Doc PR        | N/A
    
    RFC 4627 does not dictate escaping of HTML special characters
    
    Commits
    -------
    
    72b6c9e Update misleading comment about RFC4627
    nicolas-grekas committed Sep 6, 2016
  6. bug #19842 [FrameworkBundle] Check for class existence before is_subc…

    …lass_of (chalasr)
    
    This PR was merged into the 2.7 branch.
    
    Discussion
    ----------
    
    [FrameworkBundle] Check for class existence before is_subclass_of
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | n/a
    | License       | MIT
    | Doc PR        | n/a
    
    Same as #19342
    
    Commits
    -------
    
    8a9e0f5 [FrameworkBundle] Check for class existence before is_subclass_of
    nicolas-grekas committed Sep 6, 2016
  7. bug #19836 [VarDumper] Make ClassStub handle missing classes or metho…

    …ds (nicolas-grekas)
    
    This PR was merged into the 3.2-dev branch.
    
    Discussion
    ----------
    
    [VarDumper] Make ClassStub handle missing classes or methods
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | yes (well, missing feat in previous PR)
    | Tests pass?   | yes
    | License       | MIT
    
    So that one can still add ellipses when dumping about non existing classes or methods.
    
    Commits
    -------
    
    73b3cf7 [VarDumper] Make ClassStub handle missing classes or methods
    nicolas-grekas committed Sep 6, 2016
  8. minor #19862 Update GroupSequence.php (vudaltsov)

    This PR was submitted for the 3.0 branch but it was merged into the 2.7 branch instead (closes #19862).
    
    Discussion
    ----------
    
    Update GroupSequence.php
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | no
    | License       | MIT
    | Doc PR        | no
    
    Corrected the docblock example
    
    Commits
    -------
    
    c8f3741 Update GroupSequence.php
    nicolas-grekas committed Sep 6, 2016
  9. Update GroupSequence.php

    Corrected the docblock example
    vudaltsov committed with nicolas-grekas Sep 5, 2016
  10. minor #19830 Code enhancement and cleanup (yceruto)

    This PR was squashed before being merged into the 2.7 branch (closes #19830).
    
    Discussion
    ----------
    
    Code enhancement and cleanup
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | no
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | -
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    325da3c Code enhancement and cleanup
    nicolas-grekas committed Sep 6, 2016
Commits on Sep 5, 2016
  1. minor #19861 [Form] Fix intl related failures (jakzal)

    This PR was merged into the 2.8 branch.
    
    Discussion
    ----------
    
    [Form] Fix intl related failures
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.8
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #19854
    | License       | MIT
    | Doc PR        | -
    
    Commits
    -------
    
    aa3c66e [Form] Fix transformer tests after the ICU update
    fabpot committed Sep 5, 2016
  2. bug #19849 [Workflow] Make PropertyAccess required dependency (OndraM)

    This PR was merged into the 3.2-dev branch.
    
    Discussion
    ----------
    
    [Workflow] Make PropertyAccess required dependency
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master (3.2 is not yet released)
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | N/A
    | Fixed tickets | N/A
    | License       | MIT
    | Doc PR        | N/A
    
    Hi, when using Workflow as a standalone component (and instantiating new `Workflow()` instance), I'm getting errors like:
    
    ```
    PHP Fatal error:  Class 'Symfony\Component\PropertyAccess\PropertyAccess' not found in .../workflow-example/vendor/symfony/workflow/MarkingStore/PropertyAccessorMarkingStore.php on line 37
    ```
    
    The reason is the PropertyAccessorMarkingStore (and the ScalarMarkingStore as well) [uses](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Workflow/MarkingStore/PropertyAccessorMarkingStore.php#L14) PropertyAccess class. So it is basically not possible to use the component without the symfony/property-access.
    
    Is this correct @lyrixx?
    
    Commits
    -------
    
    5957412 [Workflow] Make PropertyAccess required dependency
    fabpot committed Sep 5, 2016
Commits on Sep 4, 2016
  1. Revert "minor #19689 [DI] Cleanup array_key_exists (ro0NL)"

    This reverts commit c89f80a, reversing
    changes made to 386e5e7.
    nicolas-grekas committed Sep 4, 2016
Commits on Sep 3, 2016
  1. bumped Symfony version to 3.1.5

    fabpot committed Sep 3, 2016
  2. Merge pull request #19838 from fabpot/release-3.1.4

    released v3.1.4
    fabpot committed on GitHub Sep 3, 2016
  3. updated VERSION for 3.1.4

    fabpot committed Sep 3, 2016
  4. updated CHANGELOG for 3.1.4

    fabpot committed Sep 3, 2016
Commits on Sep 2, 2016
  1. Merge pull request #19831 from fabpot/release-2.8.10

    released v2.8.10
    fabpot committed on GitHub Sep 2, 2016
  2. updated VERSION for 2.8.10

    fabpot committed Sep 2, 2016
  3. updated CHANGELOG for 2.8.10

    fabpot committed Sep 2, 2016
  4. bug #19827 [BrowserKit] Fix cookie expiration on 32 bit systems (jame…

    …shalsall)
    
    This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #19827).
    
    Discussion
    ----------
    
    [BrowserKit] Fix cookie expiration on 32 bit systems
    
    | Q             | A
    | ------------- | ---
    | Branch?       | 2.7
    | Bug fix?      | yes
    | New feature?  | no
    | BC breaks?    | no
    | Deprecations? | no
    | Tests pass?   | yes
    | Fixed tickets | #15739
    | License       | MIT
    
    On 32-bit systems the cookie expiration value was not being calculated
    correctly as it was being fetched as an integer. When the timestamp exceeded
    the PHP_INT_MAX size it would return an invalid value, breaking the cookie
    construction.
    
    The BrowserKit cookie has now been updated to get the timestamp as a string
    which works around this platform limitation (similar to how it works in the Cookie
    from HttpFoundation).
    
    Commits
    -------
    
    68698f2 [BrowserKit] Fix cookie expiration on 32 bit systems
    fabpot committed Sep 2, 2016
  5. [BrowserKit] Fix cookie expiration on 32 bit systems

    On 32-bit systems the cookie expiration value was not being calculated
    correctly as it was being fetched as an integer. When the timestamp exceeded
    the PHP_INT_MAX size it would return an invalid value, breaking the cookie
    construction.
    
    The BrowserKit cookie has now been updated to get the timestamp as a string
    which works around this platform limitation.
    jameshalsall committed with fabpot Sep 2, 2016
  6. minor #19828 [VarDumper] LinkStub fix (nicolas-grekas)

    This PR was merged into the 3.2-dev branch.
    
    Discussion
    ----------
    
    [VarDumper] LinkStub fix
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | Bug fix?      | yes
    | Tests pass?   | yes
    | License       | MIT
    
    Hum...
    
    Commits
    -------
    
    9488596 [VarDumper] LinkStub fix
    nicolas-grekas committed Sep 2, 2016
  7. feature #19826 [VarDumper] Add ClassStub for clickable & shorter PHP …

    …identifiers (nicolas-grekas)
    
    This PR was merged into the 3.2-dev branch.
    
    Discussion
    ----------
    
    [VarDumper] Add ClassStub for clickable & shorter PHP identifiers
    
    | Q             | A
    | ------------- | ---
    | Branch?       | master
    | New feature?  | yes
    | Tests pass?   | yes
    | License       | MIT
    | Doc PR        | symfony/symfony-docs#6946
    
    Tells dumpers when PHP identifiers are used so that they can shorten the namespace and create IDE links to the source.
    
    ![capture du 2016-09-02 17-07-06](https://cloud.githubusercontent.com/assets/243674/18208461/df2c9684-712f-11e6-9fea-de13e21f86c3.png)
    
    (PR also embeds some fixes/cleanups)
    
    Commits
    -------
    
    788f7e8 [VarDumper] Add ClassStub for clickable & shorter PHP identifiers
    fabpot committed Sep 2, 2016