Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test.com for test_timeout_in_data_phase test? #1098

Closed
junaruga opened this issue Sep 21, 2016 · 1 comment
Closed

test.com for test_timeout_in_data_phase test? #1098

junaruga opened this issue Sep 21, 2016 · 1 comment

Comments

@junaruga
Copy link
Contributor

This is just question.
Can I ask about test_timeout_in_data_phase test?

https://github.com/puma/puma/blob/v3.6.0/test/test_puma_server.rb#L313

client << "POST / HTTP/1.1\r\nHost: test.com\r\nContent-Type: text/plain\r\nContent-Length: 5\r\n\r\n"

is this test connecting http://test.com/ ?
What is this site?

If possible, I do not want to connect to internet outside for test because of my test environment's situation.

System configuration

Ruby version:

ruby -v
ruby 2.3.1p112 (2016-04-26 revision 54768) [x86_64-linux]

Rails version:

None

Thanks.

@evanphx
Copy link
Member

evanphx commented Sep 21, 2016

No, it's not connecting to test.com, it's just sending that as the Host header. There isn't really a reason to be doing that either, that's just a really old test.

@evanphx evanphx closed this as completed Sep 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants