Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for frozen string literal compatibility. #1376

merged 1 commit into from Aug 3, 2017


Copy link

@pat pat commented Jul 22, 2017

These changes allow the tests to run with RUBYOPT="--enable-frozen-string-literal" - well, except for the last three tests in test/test_integration.rb, which were hanging for me, so I added temporary skip statements in (though this happens without the env variable too - a quirk of my system, I guess).

At the current point in time, Rubocop is not frozen-string-literal friendly, as it depends on parser (which I've got a pending PR submitted for), but parser depends on racc (which has existing PRs from quite some time ago, not yet merged). So, if anyone knows anything about racc, would love your input there, as the maintainer of parser is happy enough with my patch but wants racc patched first. Due to the compiling nature of parser, it can't be used as a git reference in Gemfiles, so this is certainly more of a roadblock than I'd like.

All of that is to say: there's no point setting the RUBYOPT flag for MRI 2.4+ in the Travis configuration until these dependencies are sorted, which means there's the possibility of introducing regressions in the meantime.


@nateberkopec nateberkopec modified the milestone: 3.10.0 Aug 3, 2017
@nateberkopec nateberkopec merged commit b25dc5d into puma:master Aug 3, 2017
Copy link
Contributor Author

pat commented Aug 3, 2017

Thanks Nate :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants